Contest entry loading icon shows on every entry when voting

[cl8n]

this spinning loading icon shows on every entry except the one being voted for. the star turns a lighter color after the vote request finishes, so I feel like this loading icon doesn't need to exist at all

picture is taken right after clicking on the vote button

[nekodex]

The spinner definitely needs to still exist (probably just on the current vote being cast) - not everyone in the world has amazing internet, so feedback should be provided indicating that their vote has been cast properly.

[cl8n]

the star changes color once the vote is cast, so there already is feedback. the loading icon would be a little more obvious though

[nekodex]

IIRC the star changes colour immediately on click and not after request completion - meaning if the request fails (i.e. internet cuts out, etc), then the user would be none the wiser and think their vote went through when it didn't...

[nekodex]

Just to add some background (originally posted in #4752):

When the page was first written, it was done in such a way that only one voting action could be performed at once (i.e. no async voting). That's why the spinner was made visible on all the entries at the same time - to give clear feedback to the user that you can't currently make another vote.

A proper fix for this involves more than just changing which spinners are displayed - it would need to update the voting system to be able to handle asynchronous voting (remembering to keep track of outgoing votes vs max number of votes for the current contest and rolling back votes when errors occur, etc), but that's more complicated which is why it wasn't done initially.

[nanaya]

Before I forgot about this again, the change should be more or less:

• each component manages its own loading state
• when adding vote, tell the top component to reduce one available vote (and revert on failure)
• when removing vote, wait until the process is done before telling the top component to add one available vote