Add group history page #10430
Open
Add group history page #10430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 7, 2023
This also includes all groups the user can normally view, for use in a group selector
lol
cl8n
force-pushed
the
group-history-2
branch
from
ebcc04d
to
80eb4e3
Compare
nanaya
requested changes
Feb 20, 2024
Comment on lines
+5
to
+11
| &__events { | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 10px; | ||
| } | ||
|
|
||
| &__none { |
There was a problem hiding this comment.
those are more like modifiers rather than elements.
| return ( | ||
| <form className={bn} data-loading-overlay='0' onSubmit={this.onSubmit}> | ||
| <div className={`${bn}__content ${bn}__content--inputs`}> | ||
| <InputContainer for='group' labelKey='group_history.form.group'> |
Comment on lines
+42
to
+44
| <div className={`${bn}__select-container`}> | ||
| <select | ||
| className={`${bn}__input`} |
There was a problem hiding this comment.
interleaving the block hasn't been a good idea. this also caused repeating of the styling
| {trans('group_history.form.group_all')} | ||
| </option> | ||
| {groupStore.all.map((group) => ( | ||
| <option key={group.id} value={group.identifier}> |
There was a problem hiding this comment.
the dropdown is unreadable with white/gray background. Also the dropdown arrow doesn't align quite right
| import { action, computed, makeObservable, observable } from 'mobx'; | ||
|
|
||
| class GroupStore { | ||
| @observable byId = observable.map<number, GroupJson>(); |
There was a problem hiding this comment.
observable.map can just be normal object
| }; | ||
|
|
||
| if ('playmodes' in event && event.playmodes != null) { | ||
| mappings.playmodes = transArray( |
There was a problem hiding this comment.
should probably be called ruleset
Comment on lines
+13
to
+28
| @icons: { | ||
| group-add: users; | ||
| group-remove: users-slash; | ||
| group-rename: users-cog; | ||
| user-add: user-plus; | ||
| user-add-playmodes: user-tag; | ||
| user-remove: user-minus; | ||
| user-remove-playmodes: user-tag; | ||
| user-set-default: user-cog; | ||
| }; | ||
| each(@icons, { | ||
| .@{_top}--@{key} & { | ||
| @icon-var: 'fa-var-@{value}'; | ||
| --icon: @@icon-var; | ||
| } | ||
| }); |
There was a problem hiding this comment.
set at block level? Also for the message bold styling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part 4~ resolves #6216
full page screenshots
the search form is basically same as featured artists track search and the events list is basically same as user profile recent activity area. the icon BGs light up with the group's color, if it has one.
This page is now available at https://osu.ppy.sh/groups/history.