Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surround query with quotes when clicking on title, artist or source on beatmapset page #10713

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Surround query with quotes when clicking on title, artist or source on beatmapset page #10713

merged 4 commits into from
Nov 13, 2023

Conversation

Swekka
Copy link
Contributor

@Swekka Swekka commented Nov 7, 2023 •
edited

nanaya
nanaya requested changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@nanaya nanaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not quite working yet (to be improved by #10716) but it should be double (double) quoted (title=""the title"").

@Swekka
Copy link
Contributor Author

Swekka commented Nov 10, 2023

Isn't it planned to use title="the title"! for full matching? (#10377)

@nanaya
Copy link
Collaborator

nanaya commented Nov 10, 2023

I don't know when that will happen. Adding support for that is a bit more involved. The double double quoting is for searching the words in specified order.

@Swekka
Copy link
Contributor Author

Swekka commented Nov 10, 2023

Oh, I see, I thought single quotes already did that.

@Swekka Swekka requested a review from nanaya November 10, 2023 13:52
@nanaya nanaya merged commit ed285c7 into ppy:master Nov 13, 2023
3 checks passed
@Swekka Swekka deleted the beatmapset-query-quotes branch November 13, 2023 08:11
@Mrgglock Mrgglock mentioned this pull request Dec 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanaya nanaya nanaya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase the search accuracy when clicking source's super link on map's description
2 participants
@Swekka @nanaya