Use table-based user cover presets #11116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notbakaneko
requested changes
Apr 8, 2024
|
|
||
| import UserCoverPresetBatchActivate from 'user-cover-preset-batch-activate'; | ||
|
|
||
| new UserCoverPresetBatchActivate(); |
There was a problem hiding this comment.
constructing an object and not assigning it is weird as it implies there's no reference to it and it should get gc'd but it doesn't from the global handlers in it (also smells like using new to create side-effect). Use a static initializer and private constructor instead.
There was a problem hiding this comment.
why are you reviewing something from previous pr ಠ_ಠ
| @@ -29,6 +28,23 @@ export default class CoverSelector extends React.Component<Props> { | |||
| private readonly eventId = `users-show-cover-selector-${nextVal()}`; | |||
| private readonly uploaderRef = React.createRef<CoverUploader>(); | |||
|
|
|||
| @computed | |||
| private get holdoverCoverPreset(): UserCoverPresetJson|null { | |||
| <CoverSelection | ||
| confirmUpdate={confirmUpdate} |
There was a problem hiding this comment.
just false? or default false
| use App\Transformers\UserCoverPresetTransformer; | ||
| use Illuminate\Support\Collection; | ||
|
|
||
| class UserCoverPresets |
There was a problem hiding this comment.
wonder if it's worth calling resetMemoized() when the covers are updated in the controller?
notbakaneko
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤷