New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use command name instead of display name in datadog metric #11165
Merged
nanaya
merged 5 commits into
ppy:master
from
notbakaneko:queue-datadog-log-command-name
Apr 24, 2024
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
caa3aa9
log command name in metric instead of displayName;
notbakaneko c7bdfb9
test commandName in job payload is the value we expect
notbakaneko efd371e
wrong displayName test
notbakaneko 7f5b514
update name
notbakaneko e1fbd38
Merge branch 'master' into queue-datadog-log-command-name
nanaya File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
<?php | ||
|
||
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the GNU Affero General Public License v3.0. | ||
// See the LICENCE file in the repository root for full licence text. | ||
|
||
declare(strict_types=1); | ||
|
||
namespace Tests\Jobs; | ||
|
||
use Illuminate\Queue\Events\JobProcessed; | ||
use Queue; | ||
use Tests\TestCase; | ||
|
||
class JobNameTest extends TestCase | ||
{ | ||
public function testDisplayName() | ||
{ | ||
$job = new TestJob('test'); | ||
|
||
Queue::after(function (JobProcessed $event) use ($job) { | ||
$payload = $event->job->payload(); | ||
$this->assertSame($job::class, $payload['data']['commandName']); | ||
$this->assertSame($job->displayName(), $payload['displayName']); | ||
}); | ||
|
||
dispatch($job); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
<?php | ||
|
||
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the GNU Affero General Public License v3.0. | ||
// See the LICENCE file in the repository root for full licence text. | ||
|
||
namespace Tests\Jobs; | ||
|
||
use Illuminate\Bus\Queueable; | ||
use Illuminate\Contracts\Queue\ShouldQueue; | ||
|
||
class TestJob implements ShouldQueue | ||
{ | ||
use Queueable; | ||
|
||
public function __construct(private $name) | ||
{ | ||
} | ||
|
||
public function displayName() | ||
{ | ||
return $this->name; | ||
} | ||
|
||
public function handle() | ||
{ | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can use a test to avoid getting trolled by laravel