Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly clean the username #1867

Merged
merged 2 commits into from Jan 31, 2018
Merged

Properly clean the username #1867

merged 2 commits into from Jan 31, 2018

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented Dec 1, 2017

Woo magic setter ┐(' ヮ' )┌

@nanaya
Copy link
Collaborator Author

nanaya commented Jan 9, 2018

Rebased and updated to match current behavior ┐(･ ヮ･ )┌

notbakaneko
notbakaneko approved these changes Jan 31, 2018
View reviewed changes
Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

┐(・ヮ・)┌

@notbakaneko notbakaneko merged commit e137471 into ppy:master Jan 31, 2018
@nanaya nanaya deleted the unique_ish_username branch January 31, 2018 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notbakaneko notbakaneko notbakaneko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nanaya @notbakaneko