New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow newline between various tags #2313
Conversation
Uhh, I guess for some reason there's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can just use the /s
modifier for multi-line matching: /pattern/s
@@ -155,6 +155,17 @@ public function parseInlineSimple($text) | |||
return $text; | |||
} | |||
|
|||
public function parseHeading($text) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
you don't have to merge |
🤔 Well GitHub throws a triangle at me with an exclamation mark every time it's "out-of-date" and a big button to update it, so I thought that was the right ting to do. |
Should fix #268
for color tags.I'll allow myself a question. How do I put regular expressions in code like this?Never mind, I think I figured it out myself.
Still I'm not really sure what I'm doing, just tried following the patterns. Added a function parseHeading because headings were passed in parseInlineSimple, which I made to pass multiline things, and headings shouldn't be multiline.
Also shouldn't I have renamed the "inline" function, since it now parses multiline? 🙅♂️🔫