Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out empty string username_last #3032

Merged
merged 1 commit into from
Apr 18, 2018
Merged

Filter out empty string username_last #3032

merged 1 commit into from
Apr 18, 2018

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented Apr 18, 2018

There's null, and then there's empty string.

notbakaneko
notbakaneko approved these changes Apr 18, 2018
View reviewed changes
Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like a job for Oracle

@notbakaneko notbakaneko merged commit 2a6704f into ppy:master Apr 18, 2018
@nanaya nanaya deleted the username_history_filter branch May 21, 2018 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notbakaneko notbakaneko notbakaneko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nanaya @notbakaneko