Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add played filter to beatmap listing #3051

Merged
merged 12 commits into from
Apr 23, 2018
Merged

Add played filter to beatmap listing #3051

merged 12 commits into from
Apr 23, 2018

Commits on Apr 20, 2018

  1. added for type hinting

    @notbakaneko
    notbakaneko committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    d0bb0ba View commit details
    Browse the repository at this point in the history

  2. add played/unplayed filter to BeatmapsetSearch

    @notbakaneko
    notbakaneko committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    d2f5daa View commit details
    Browse the repository at this point in the history

  3. add played state filter to beatmap listing page

    @notbakaneko
    notbakaneko committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    8746352 View commit details
    Browse the repository at this point in the history

  4. pass played state param to search

    @notbakaneko
    notbakaneko committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    7ae530c View commit details
    Browse the repository at this point in the history

  5. remove overriding type-hiting variable

    @notbakaneko
    notbakaneko committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    682d087 View commit details
    Browse the repository at this point in the history

  6. update isCacheable check to handle played state

    @notbakaneko
    notbakaneko committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    7214bcb View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2018

  1. old code is old

    @notbakaneko
    notbakaneko committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    5633db9 View commit details
    Browse the repository at this point in the history

  2. should be set only if present

    @notbakaneko
    notbakaneko committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    5efbaca View commit details
    Browse the repository at this point in the history

  3. less cryptic parameter

    @notbakaneko
    notbakaneko committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    290da05 View commit details
    Browse the repository at this point in the history

  4. rename playedState to playedFilter; 

    since param signifies presence of filtering
    @notbakaneko
    notbakaneko committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    86a4d4b View commit details
    Browse the repository at this point in the history

  5. change querystring param. 

    'p' is not very informative..
    @notbakaneko
    notbakaneko committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    79e50d9 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into feature/beatmap-listing-unplayed-filter-re… 

    …base
    @nanaya
    nanaya committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    bcf93e3 View commit details
    Browse the repository at this point in the history