Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load profile page extra sections #9327

Closed

Conversation

notbakaneko
Copy link
Collaborator

@notbakaneko notbakaneko commented Sep 30, 2022

Avoid loading all data on page load.
~25 queries on first load instead of ~70

Part 2 of ?(3?)

Scroll position update if a lazy loaded area above the current scroll position loads in will be handled in another PR

@notbakaneko notbakaneko self-assigned this Sep 30, 2022
@notbakaneko notbakaneko force-pushed the feature/user-profile-lazy-load branch 4 times, most recently from b140691 to 6a9a517 Compare October 3, 2022 09:34
@notbakaneko notbakaneko force-pushed the feature/user-profile-lazy-load branch from 6a9a517 to c34ef03 Compare October 3, 2022 12:58
@nanaya
Copy link
Collaborator

nanaya commented Oct 4, 2022

Scroll position update if a lazy loaded area above the current scroll position loads in will be handled in another PR

Clicking on any of the page section link before anything loads also results in nonsense scroll position...

Also the intersection margin should be a lot larger than current 0.

And a retry button would be useful.

there's also the part where if someone opens multiple tabs of profile and they actually check the tabs they'll still be faced with spinners if they don't scroll each tabs down beforehand but that's just the result of lazy loading

@notbakaneko notbakaneko marked this pull request as draft October 6, 2022 08:43
@notbakaneko notbakaneko marked this pull request as ready for review October 11, 2022 12:54
@nanaya
Copy link
Collaborator

nanaya commented Oct 12, 2022

I'm reviewing this in #9363 because otherwise the profile page will be half broken if this gets deployed before the other one.

@nanaya
Copy link
Collaborator

nanaya commented Nov 8, 2022

As mentioned above, this will be reviewed as part of #9363.

@nanaya nanaya closed this Nov 8, 2022
@notbakaneko notbakaneko deleted the feature/user-profile-lazy-load branch January 17, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants