Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Community Contributors #2075

Merged
merged 22 commits into from
Mar 12, 2019
Merged

Update Community Contributors #2075

merged 22 commits into from
Mar 12, 2019

Conversation

MegaApplePi
Copy link
Contributor

Add the 2019 Community Contributors and other stuff.

WalterToro and others added 2 commits February 21, 2019 18:25
@WalterToro @MegaApplePi
People/CC: Fix another typo
3190a9e 
Co-Authored-By: MegaApplePi <eric@m9pi.net>
@MegaApplePi @cl8n
People/CC: correct the 2019 heading
c79b701 
Co-authored-by: cl8n <me@clayton.cc>
Joehuu
Joehuu requested changes Feb 22, 2019
View reviewed changes
Copy link
Member

@Joehuu Joehuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per ASC and the Mascots article for consistency on the hatnotes.

wiki/People/Community_Contributors/en.md Outdated Show resolved Hide resolved
wiki/People/Community_Contributors/en.md Outdated Show resolved Hide resolved
wiki/People/Community_Contributors/en.md Outdated Show resolved Hide resolved
wiki/People/Community_Contributors/en.md Outdated Show resolved Hide resolved
wiki/People/Community_Contributors/en.md Outdated Show resolved Hide resolved
wiki/People/Community_Contributors/en.md Outdated Show resolved Hide resolved
wiki/People/Community_Contributors/en.md Outdated Show resolved Hide resolved
wiki/People/Community_Contributors/en.md Outdated Show resolved Hide resolved
wiki/People/Community_Contributors/en.md Outdated Show resolved Hide resolved
wiki/People/Community_Contributors/en.md Outdated Show resolved Hide resolved
Joehuu and others added 4 commits February 21, 2019 18:32
@Joehuu @MegaApplePi
People/CC: Make hatnotes ASC-compliant
29b29b5 
Co-Authored-By: MegaApplePi <eric@m9pi.net>
@Joehuu @MegaApplePi
People/CC: table ASC fixes (again)
e97e002 
for real this time

Co-Authored-By: MegaApplePi <eric@m9pi.net>
@MegaApplePi @WalterToro
People/CC: revert 2013 thread link
7491d50 
WalterToro brought it back from the wasteland

Co-authored-by: WalterToro <walterion0@gmail.com>
@MegaApplePi @Joehuu @WalterToro
People/CC: add flags
178344e 
Finally, I got to use the thing I created

Co-authored-by: Joehuu <madamba.joehu@outlook.com>
Co-authored-by: WalterToro <walterion0@gmail.com>
@MegaApplePi
Copy link
Contributor Author

MegaApplePi commented Feb 22, 2019 •
edited

do we put flags its own column to prevent it from wrapping in the table?

/edit
never mind, forgot that tables auto size the column widths to fit their content. As images don't have a minimum width, they downsize into a dot.

@Joehuu
Copy link
Member

Joehuu commented Feb 22, 2019

if it makes it look better, yeah.

@sr229
Copy link
Contributor

sr229 commented Feb 22, 2019

2013-2015 entries have merge conflicts.

@MegaApplePi
Copy link
Contributor Author

alright, thought I resolved those

MegaApplePi and others added 3 commits February 21, 2019 20:56
@MegaApplePi
Actually resolve conflicts
e6e3772 
no wonder why VSCode kept warning me about some conflicts

Co-authored-by: sr229 <enra@sayonika.moe>
@MegaApplePi
Revert "People/CC: correct the 2019 heading"
50da54e 
This reverts commit c79b701.

Announcement and badges were issed issused in 2019
@MegaApplePi
People/CC: ekr is another 2019 community contributor
d64f1ec
cl8n
cl8n requested changes Feb 22, 2019
View reviewed changes
wiki/People/Community_Contributors/en.md Outdated Show resolved Hide resolved
@TPGPL
Copy link
Contributor

TPGPL commented Feb 22, 2019

Forgot to add the flag references?

@MegaApplePi
People/CC: other fixes
d5ae310 
Fix 2019 announcement post link and text
Move ekr to bottom
Put back flag references
Joehuu
Joehuu previously approved these changes Feb 23, 2019
View reviewed changes
@TPGPL TPGPL added the update label Feb 23, 2019
cl8n
cl8n requested changes Feb 23, 2019
View reviewed changes
Copy link
Member

@cl8n cl8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be under a February sub-heading, like 2016

@MegaApplePi
Copy link
Contributor Author

MegaApplePi commented Feb 24, 2019 •
edited

Add it now? I think it should wait until if there is another announcement in the same year. 2016 had three different announcements, while the others just had one (which was why I removed the months for those ones). Unless, you think they should all have month sub-headings?

@cl8n
Copy link
Member

cl8n commented Feb 24, 2019

they should only have months if they specify it in the announcement, I think
so 2017 stays just 2017, while 2019 becomes 2019 > February

@MegaApplePi
Copy link
Contributor Author

I don't think that works well with 2016, but alright, adding the February heading and putting back the others to keep some consistency.

@MegaApplePi
People/CC: Put back month sub-headings
0e8e97c 
and add December 2017 and February 2019's headings
Joehuu
Joehuu requested changes Feb 24, 2019
View reviewed changes
Copy link
Member

@Joehuu Joehuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add outdated tags to translations.

@Shadowthegod
Copy link
Contributor

This line break looks horrible, not sure if its fixable tho

@MegaApplePi
Copy link
Contributor Author

MegaApplePi commented Feb 24, 2019 •
edited

adding a non-breaking space should prevent it from doing that, but not sure if we go in that direction

/edit
Forgot that a non-breaking space does not work with an image and text. Fwiw some CSS would need to be used to prevent the wrapping.

@WalterToro
Copy link
Contributor

I dont know if it can be fixed with an extra column for the flags, probably best to try

@MegaApplePi
Copy link
Contributor Author

I have already tried that in 912176f. The column widths auto adjust their size to fit everything inside but since images don't have a minimum width, their column shrinks width-wise and they downsize.

Joehuu
Joehuu previously approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@Joehuu Joehuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add the outdated tags on another PR if author is inactive.

@MegaApplePi
Copy link
Contributor Author

oh, kept skipping over your review comment. I'll add them in a couple hours

@Repflez Repflez merged commit 3c6dca8 into ppy:master Mar 12, 2019
@MegaApplePi MegaApplePi deleted the cc-2019 branch March 12, 2019 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterToro WalterToro WalterToro left review comments

@cl8n cl8n cl8n requested changes

@Repflez Repflez Repflez approved these changes

@Joehuu Joehuu Joehuu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@MegaApplePi @Joehuu @sr229 @TPGPL @cl8n @Shadowthegod @WalterToro @Repflez