Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup MediaWiki leavings in the Modding article #2079

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Conversation

TPGPL
Copy link
Contributor

@TPGPL TPGPL commented Feb 22, 2019

No description provided.

Copy link
Member

@cl8n cl8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

none of the glossary entries are linked to their anchor (what's the reason for that?)

@TPGPL
Copy link
Contributor Author

TPGPL commented Feb 23, 2019

because they need to be translated so they can work

@TPGPL TPGPL added the update label Feb 23, 2019
@cl8n
Copy link
Member

cl8n commented Feb 23, 2019

this makes it a little difficult for translators though, like when they go through these articles again I really doubt they'll realise that the glossary links need to be updated

@cl8n
Copy link
Member

cl8n commented Feb 23, 2019

maybe add a comment before the affected lines?

@Joehuu
Copy link
Member

Joehuu commented Feb 24, 2019

Glossary does not even have any translations, so it's fine.

@Repflez Repflez merged commit 4c49b4b into ppy:master Mar 11, 2019
@TPGPL TPGPL deleted the modding branch September 8, 2019 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants