New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osu!catch RC Cleanup #2428
osu!catch RC Cleanup #2428
Conversation
Adjusts definitions, changes some too-old terminology, removes redundant rules, and updates some new stuff based on discussion
proofreading edits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of these comments are about things u didnt actually change in this PR but w/e
Co-Authored-By: clayton <me@clayton.cc>
Co-Authored-By: clayton <me@clayton.cc>
Co-Authored-By: clayton <me@clayton.cc>
for commit messages and PR titles describe your changes in present tense, for example instead of "osu!catch RC Cleanup" it should be "Clean up osu!catch RC" not that important but this is good git practice |
more stuff is bolded, applied stuff from cl8n
did more stuff, should be ok now |
grammar and stuff
Co-Authored-By: clayton <me@clayton.cc>
what an adventure |
fixed more bold stuff in expert guidelines
Please don't use version numbering on commit titles next time. The commit description "fixed more bold stuff in expert guidelines" should've been the commit title instead and have an imperative mood ( |
it was more for me to keep track of what was fixed bcs im bad at github but if its a serious problem then np lol |
minor thing, but #ms and # ms are used interchangeably. should stick with one format throughout the article. same for bpm/BPM capitalization/spacing |
Units should have a space before them (so e.g. "250 ms"), and since BPM is an acronym, it should be capitalised. |
**ms -> ** ms bpm -> BPM
Adjusts definitions, changes some too-old terminology, removes redundant rules, and updates some new stuff based on discussion