Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osu!catch RC Cleanup #2428

Merged
merged 10 commits into from Aug 28, 2019
Merged

osu!catch RC Cleanup #2428

merged 10 commits into from Aug 28, 2019

Conversation

ascendancelol
Copy link
Contributor

Adjusts definitions, changes some too-old terminology, removes redundant rules, and updates some new stuff based on discussion

Adjusts definitions, changes some too-old terminology, removes redundant rules, and updates some new stuff based on discussion
proofreading edits
@osuZiRoX
Copy link
Contributor

Copy link
Member

@cl8n cl8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of these comments are about things u didnt actually change in this PR but w/e

wiki/Ranking_Criteria/osu!catch/en.md Outdated Show resolved Hide resolved
wiki/Ranking_Criteria/osu!catch/en.md Show resolved Hide resolved
wiki/Ranking_Criteria/osu!catch/en.md Outdated Show resolved Hide resolved
wiki/Ranking_Criteria/osu!catch/en.md Show resolved Hide resolved
wiki/Ranking_Criteria/osu!catch/en.md Outdated Show resolved Hide resolved
wiki/Ranking_Criteria/osu!catch/en.md Show resolved Hide resolved
wiki/Ranking_Criteria/osu!catch/en.md Outdated Show resolved Hide resolved
wiki/Ranking_Criteria/osu!catch/en.md Outdated Show resolved Hide resolved
wiki/Ranking_Criteria/osu!catch/en.md Outdated Show resolved Hide resolved
wiki/Ranking_Criteria/osu!catch/en.md Outdated Show resolved Hide resolved
ascendancelol and others added 3 commits August 14, 2019 16:07
Co-Authored-By: clayton <me@clayton.cc>
Co-Authored-By: clayton <me@clayton.cc>
Co-Authored-By: clayton <me@clayton.cc>
@cl8n
Copy link
Member

cl8n commented Aug 14, 2019

for commit messages and PR titles describe your changes in present tense, for example instead of "osu!catch RC Cleanup" it should be "Clean up osu!catch RC"

not that important but this is good git practice

more stuff is bolded, applied stuff from cl8n
@ascendancelol
Copy link
Contributor Author

did more stuff, should be ok now

wiki/Ranking_Criteria/osu!catch/en.md Outdated Show resolved Hide resolved
wiki/Ranking_Criteria/osu!catch/en.md Outdated Show resolved Hide resolved
grammar and stuff
wiki/Ranking_Criteria/osu!catch/en.md Outdated Show resolved Hide resolved
Co-Authored-By: clayton <me@clayton.cc>
@ascendancelol
Copy link
Contributor Author

what an adventure

cl8n
cl8n previously approved these changes Aug 14, 2019
fixed more bold stuff in expert guidelines
@Joehuu
Copy link
Member

Joehuu commented Aug 14, 2019

Please don't use version numbering on commit titles next time. The commit description "fixed more bold stuff in expert guidelines" should've been the commit title instead and have an imperative mood (Fix).

@ascendancelol
Copy link
Contributor Author

it was more for me to keep track of what was fixed bcs im bad at github but if its a serious problem then np lol

@pishifat
Copy link
Contributor

minor thing, but #ms and # ms are used interchangeably. should stick with one format throughout the article. same for bpm/BPM capitalization/spacing

@JBHyperion
Copy link
Contributor

minor thing, but #ms and # ms are used interchangeably. should stick with one format throughout the article. same for bpm/BPM capitalization/spacing

Units should have a space before them (so e.g. "250 ms"), and since BPM is an acronym, it should be capitalised.

**ms -> ** ms
bpm -> BPM
@WalterToro WalterToro merged commit 5179ac9 into ppy:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants