Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hitsound additions requirement from Ranking criteria/osu!mania #6128

Merged
merged 3 commits into from Oct 13, 2021

Conversation

abraker95
Copy link
Contributor

Discussion at https://osu.ppy.sh/community/forums/topics/1418542 is in agreement with the proposal.

Removes the requirement of having hitsound additions in osu!mania beatmaps.

@peppy
Copy link
Sponsor Member

peppy commented Sep 18, 2021

Is it possible that we can reword this to give rationale? Something like "To allow for easier approachability to osu!mania mappers of different upbringings, hitsounds are not required. It is still highly recommended to add them to improve the feel of your beatmaps."

@abraker95
Copy link
Contributor Author

Added rationale. Very minor change from suggested to preserve "rule details" format.

@peppy
Copy link
Sponsor Member

peppy commented Sep 19, 2021

Hold off on merging this until I have a chance to read through the thread. It doesn't seem 100% cut and dry, so want to make sure I'm on the same page.

One thing to keep in mind is that hitsounds are used for converting maps, which in lazer would be used for conversions from mania to taiko, for instance. Food for thought that dropping the requirement would make such conversions no longer play well.

@TPGPL TPGPL changed the title Update Ranking Criteria Remove hitsound additions requirement from Ranking criteria/osu!mania Sep 21, 2021
@juankristal
Copy link
Contributor

juankristal commented Sep 22, 2021

I was not aware that a conversion of mania to taiko was a thing in lazer. In any case I would argue it is not that important of a thing though considering you already have the STD to any mode conversion. And to be fair, conversions never really played well from STD to mania or taiko (therefore it would probably be the same for mania to taiko if it is converted in a similar way)

@Kominaru
Copy link
Contributor

If worries about implementing this change are mania->taiko conversions (which to be fair I don't think are necessary anymore, taking into account the amount of content we have in the game now, as Juan says), there are way better ways that do not rely on hitsounds (one possibility is by using chord sizes to differentiate kats and dons).

Anyway, perhaps not the right place to discuss this but I feel something like automatic converts shouldn't halt the implementation of this change, mainly seeing that we already have this same rule for IX and X spreads.

@peppy
Copy link
Sponsor Member

peppy commented Sep 23, 2021

Forget I said anything bout converts. No further response here is required for now.

@Unpredictabl3
Copy link

Forget I said anything bout converts. No further response here is required for now.

Sorry for responding to this even though you pretty much said not to, but what's the reasoning on why this has been "halted" for a little while now? Others like myself weren't sure what's the status on this as the last thing was said 15 days ago so I just thought it'd be better to ask in here rather than just sit here and wait till someone makes a post here eventually.

@peppy
Copy link
Sponsor Member

peppy commented Oct 13, 2021

Just going to add my final opinion that this is a huge cop out and I don't support the decision. In a future update we'll make sure to mark maps clearly which don't have hitsounds, and potentially offer automatic addition of them in cases they are missing (for those users which want them).

@peppy peppy merged commit 7f90cd5 into ppy:master Oct 13, 2021
Kominaru added a commit to Kominaru/osu-wiki that referenced this pull request Feb 10, 2022
This line was added by one of the mergers in ppy#6128, not being in the original PR. Since it's misleading and contradicts other parts of the RC (it would forbid mappers to have proper volume control for the still required hitnormal support), it's necessary to remove it (this was already agreed during discussion the original PR and was confirmed recently).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants