Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unclear paths for short sliders in osu! ranking criteria #6263

Merged
merged 9 commits into from Dec 14, 2021

Conversation

UberFazz
Copy link
Contributor

@UberFazz UberFazz commented Oct 22, 2021

Based on overwhelming support from https://osu.ppy.sh/community/forums/topics/1442020.

Mappers have been utilizing sliders that can be interpreted as "unrankable" (under the current RC) for a while now. These sliders have been long accepted by the general community as can be seen by the thread. The most common use for sliders like these are sliders that require no movement to FC, such as sliders present in this map. These are perfectly fair gameplay elements for Hard+ players due to their simplicity — they'll be FC'd no matter which way they're read even if they're technically "unreadable."

image

Other uses that could be interpreted as "unrankable" would be sliders like in Dialtone, which are a bit more complicated but have similar concepts. These sliders go in on themselves but play exactly like the sliders in the aforementioned map (edited for clarity).

image

I've moved the original rule from "general" to "difficulty-specific" for Easy and Normal difficulties. For Hard and Insane, the rule now contains an exception. For Expert, the exception is shortened to allow for more leniency.

rule moved to e/n/h per-diff rules and i/x per-diff guidelines
moved from rule to guideline in h
moved h back to rule but added addendum
@AJT127
Copy link
Contributor

AJT127 commented Oct 22, 2021

Agree

@yaspo
Copy link
Contributor

yaspo commented Oct 22, 2021

I feel like some of these changes weren't properly discussed, so I posted on the discussion thread where it's appropriate
would like this pr to stay on hold until things are cleared up

@UberFazz UberFazz marked this pull request as draft October 23, 2021 00:08
@peppy
Copy link
Sponsor Member

peppy commented Oct 23, 2021

The second slider there is absolutely shocking. It's basically hiding gameplay mechanics from the player. If this is to go ahead I will need to change how sliders are presented to the player, or change such sliders to act like hitcircles internally.

peppy
peppy previously requested changes Oct 23, 2021
Copy link
Sponsor Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block

@AJT127
Copy link
Contributor

AJT127 commented Oct 23, 2021

The second slider there is absolutely shocking. It's basically hiding gameplay mechanics from the player. If this is to go ahead I will need to change how sliders are presented to the player, or change such sliders to act like hitcircles internally.

What's the functional difference between this and something like https://i.imgur.com/KSaeQUJ.png or
https://i.imgur.com/vLnHfw9.png which are already completely allowed?

Also I'm not quite sure what you mean by changing such sliders to act like hitcircles internally - they are held for a while so surely they are more similar to sliders? They're just short.

@peppy
Copy link
Sponsor Member

peppy commented Oct 23, 2021

Neither of those should be allowed.

@AJT127
Copy link
Contributor

AJT127 commented Oct 23, 2021

Could you elaborate? They both seem pretty playable especially if supported by the map

@Coppertine
Copy link
Contributor

Coppertine commented Oct 23, 2021

Neither of those should be allowed.

Note, map shown in question is in CS 10, the map is also using the lowest SV possible (0.4x SV with 0.1x). The intention is of a hold slider, the first slider which has no red anchors includes repeats.

@cl8n
Copy link
Member

cl8n commented Oct 23, 2021

keep this thread to discussion of the proposed rule please. the sliders in #6263 (comment) are not affected by it

@peppy
Copy link
Sponsor Member

peppy commented Oct 23, 2021

I don’t think these kinds of ranking criteria changes are in the best interest of the game with its current progression forward as we are rapidly iterating on game mechanics.

Sliders should be clearly readable as sliders, thus have a minimum track length to signify their object type.

Can we revisit this in six months?

@UberFazz
Copy link
Contributor Author

I'd like to clarify the aim of this proposal. Under the current RC, any kind of ambiguous slider is disallowed, regardless of gameplay. This works well at prohibiting unreadable sliders, but has the side-effect of prohibiting sliders that are fully covered by the follow circle. These sliders are harmless; no matter which direction you go, you will SS the slider.

Here's a better example as to what kind of sliders this proposal aims to permit:

image

I've edited the original post for clarity.

I've updated wording as well to reflect this more clearly, but am waiting on more opinions from the forum thread before committing.

@cl8n
Copy link
Member

cl8n commented Oct 23, 2021

@peppy I think you're misunderstanding what the proposal is for, that second screenshot in OP is showing a slider that's not only short (which is allowed by current RC) but also has a path that goes back and forth across itself before ending (not allowed by current RC).

the idea of the proposal that has wide support is that experienced players can easily read these sliders despite not technically having a clear path, so they should be rankable.

whether or not that particular example would have been mapped as a "hold note" or something given the option hasn't been part of the discussion

e: ok I said same thing as UberFazz lol, posted at same time

@peppy
Copy link
Sponsor Member

peppy commented Oct 23, 2021

I’ll need to read further. But the second example should not be allowed in the first place, so may be good to fix that with a separate change (though I guess it’s pointless if the damage is already done..)

clarified wording for h/i to prevent "infinitely looping" sliders, with i moved to rule. x was updated + moved to rule
@UberFazz
Copy link
Contributor Author

UberFazz commented Oct 23, 2021

I've pushed another commit that clarifies the intention of the rule change after some more discussion.

To sum up the goal: Allow ambiguous sliders that would be unrankable by current definition, but can be sightread SS'd even with the ambiguity in mind. This includes short sliders that fully overlap themselves for Expert difficulties, and short sliders that have ambiguous directions from the slider head — such as triangle sliders — for Hard and Insane difficulties (both pictured in the original post).

We need this to go through because as it stands, people are ranking maps that constantly break this rule even though the rule doesn't account for situations like these.

@UberFazz UberFazz requested a review from peppy October 23, 2021 22:30
@UberFazz UberFazz marked this pull request as ready for review October 23, 2021 22:30
wiki/Ranking_Criteria/osu!/en.md Outdated Show resolved Hide resolved
wiki/Ranking_Criteria/osu!/en.md Outdated Show resolved Hide resolved
wiki/Ranking_Criteria/osu!/en.md Outdated Show resolved Hide resolved
@peppy
Copy link
Sponsor Member

peppy commented Oct 26, 2021

This stuff is pretty shoddy but I'm going to absolve myself of decision making here, since it's already in a state I disagree with prior to these changes.

Unblocked from me but without approval.

@peppy peppy removed the state/blocked don't merge label Oct 26, 2021
wiki/Ranking_Criteria/osu!/en.md Outdated Show resolved Hide resolved
wiki/Ranking_Criteria/osu!/en.md Outdated Show resolved Hide resolved
wiki/Ranking_Criteria/osu!/en.md Outdated Show resolved Hide resolved
wiki/Ranking_Criteria/osu!/en.md Outdated Show resolved Hide resolved
@cl8n cl8n changed the title Relax slider rules in Ranking criteria/osu! Allow unclear paths for short sliders in osu! ranking criteria Oct 27, 2021
@cl8n cl8n removed the request for review from peppy October 27, 2021 02:26
@cl8n
Copy link
Member

cl8n commented Dec 14, 2021

uberfazz and I tried many ways to make this more technically accurate with the intention but it's kinda a pain to define this movement-related stuff better, and it's also difficult to present good example images/animations given how niche the boundaries of the rule are

may revisit it later but for now uberfazz, yaspo, and I agree this is at least good enough resolve RC thread and most mappers will understand the meaning anyway

@cl8n cl8n merged commit 54114a6 into ppy:master Dec 14, 2021
@UberFazz UberFazz deleted the relax-slider-rules branch December 14, 2021 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants