Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ranking Criteria #7433

Merged
merged 14 commits into from Jun 10, 2022
Merged

Update Ranking Criteria #7433

merged 14 commits into from Jun 10, 2022

Conversation

pishifat
Copy link
Contributor

@pishifat pishifat commented Jun 3, 2022

applying a handful of mostly minor changes from the rc subforum. i'm planning to use footnotes to make the rest of the article easier to read once this is merged

changes:


  • NAT approval
  • peppy approval

cl8n
cl8n previously requested changes Jun 3, 2022
Copy link
Member

@cl8n cl8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs the space

wiki/Ranking_Criteria/en.md Outdated Show resolved Hide resolved
Co-authored-by: clayton <me@clayton.cc>
wiki/Ranking_Criteria/en.md Outdated Show resolved Hide resolved
wiki/Ranking_Criteria/en.md Outdated Show resolved Hide resolved
Comment on lines +233 to +234
- **Maximum width:** 2560px[^maximum-dimensions]
- **Maximum height:** 1440px[^maximum-dimensions]
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These dimensions are larger than I recall them being, kinda scary in terms of the technical requirements but I guess it's what has been in place. Also I don't know who made the storyboard rule about 17m pixels but that's pretty high too. Dangerously.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bg image context: pr, thread 1 (mostly about resolution), thread 2 (mostly about file size)

people use high-fidelity monitors these days so i can definitely understand this one. i'm not sure why a static 1440p image would cause technical concern

sb image context: pr, thread

apparently @smoogipoo suggested it, with 4096x4096 being a little under 17m

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no recollection of suggesting this, fwiw. So you can discard anything I suggested and re-evaluate as if I didn't.

Copy link
Sponsor Member

@peppy peppy Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of the forum threads mention wanting to get my opinion but either i am very forgetful (not usually the case) or that never happened 😅

people use high-fidelity monitors these days so i can definitely understand this one. i'm not sure why a static 1440p image would cause technical concern

become a developer and you will understand multiple causes for concern.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concerns aside, there are ranked storyboards with images above e.g. 10m pixels fwiw:

there aren't many (probably any) cases where large images are necessary though, because the images can just be split into multiple sprites. sakuraburst - 「skyshifter vip」 for example uses three 1920x1080 px images to create a vertical panorama

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple smaller images is definitely the preference, to the point I'd consider changing this criterial to reduce the limit to 12m or lower...

@cl8n cl8n dismissed their stale review June 3, 2022 04:08

fixed

wiki/Ranking_Criteria/en.md Outdated Show resolved Hide resolved
wiki/Ranking_Criteria/en.md Outdated Show resolved Hide resolved
Comment on lines +233 to +234
- **Maximum width:** 2560px[^maximum-dimensions]
- **Maximum height:** 1440px[^maximum-dimensions]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bg image context: pr, thread 1 (mostly about resolution), thread 2 (mostly about file size)

people use high-fidelity monitors these days so i can definitely understand this one. i'm not sure why a static 1440p image would cause technical concern

sb image context: pr, thread

apparently @smoogipoo suggested it, with 4096x4096 being a little under 17m

wiki/Ranking_Criteria/en.md Outdated Show resolved Hide resolved
@@ -30,7 +30,8 @@ Important to understand before using:
### Rules

- **No two hit objects can be placed on the same tick.** This includes hit circles and the durations of sliders and spinners. osu!mania difficulties are exempt from this.
- **No two key presses can be less than 20 milliseconds apart.** osu!mania and osu!catch difficulties are exempt from this.
- **There must be at least 10 milliseconds between a hit circle and the next object.** osu!mania and osu!catch difficulties are exempt from this.
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I didn't realise this was to be applied to osu! ruleset only..

To be honest, this can probably be removed and covered by existing timing rules (that hitobjects need to generally be snapped) at this point. Just for simplicity.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure simplifying would work too well. the map with circles 13ms apart doesn't snap them to supported timeline ticks (1/24), so it'd be unrankable by the simplification, or the logic that permits 1/24 would also permit circles <10ms apart

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine if that's the case, but would defer to others for further opinions.

peppy
peppy previously approved these changes Jun 10, 2022
Copy link
Sponsor Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking okay from my end.

@Walavouchey Walavouchey merged commit e85769c into ppy:master Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants