Merge pull request #25636 from Susko3/fix-older-android-storage

Request `READ_EXTERNAL_STORAGE` on older android versions
ppy · Dec 4, 2023 · 36b1369 · 36b1369
2 parents e06d5f5 + c2a4a6d
commit 36b1369
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/osu.Android/AndroidManifest.xml b/osu.Android/AndroidManifest.xml
@@ -5,4 +5,12 @@
 	<!-- for editor usage -->
 	<uses-permission android:name="android.permission.READ_MEDIA_IMAGES" />
 	<uses-permission android:name="android.permission.READ_MEDIA_AUDIO" />
-</manifest>
+	<!--
+		READ_MEDIA_* permissions are available only on API 33 or greater. Devices with older android versions
+		don't understand the new permissions, so request the old READ_EXTERNAL_STORAGE permission to get storage access.
+		Since the old permission has no effect on >= API 33, don't request it.
+
+		Care needs to be taken to ensure runtime permission checks target the correct permission for the API level.
+	-->
+	<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" android:maxSdkVersion="32"/>
+</manifest>