Skip to content

Commit

Permalink
Materialise realm collection hashes during song select search process
Browse files Browse the repository at this point in the history
Without this, there's a large overhead to do a realm-live `Contains`
search when a collection is selected.

This may also help considerably alleviate
#27298 (reply in thread)
as we will be performing the native realm search much less.
  • Loading branch information
peppy committed Mar 1, 2024
1 parent 85f87b6 commit 58992b2
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion osu.Game/Screens/Select/FilterControl.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#nullable disable

using System;
using System.Linq;
using osu.Framework.Allocation;
using osu.Framework.Bindables;
using osu.Framework.Graphics;
Expand Down Expand Up @@ -64,7 +65,7 @@ public FilterCriteria CreateCriteria()
Sort = sortMode.Value,
AllowConvertedBeatmaps = showConverted.Value,
Ruleset = ruleset.Value,
CollectionBeatmapMD5Hashes = collectionDropdown.Current.Value?.Collection?.PerformRead(c => c.BeatmapMD5Hashes)
CollectionBeatmapMD5Hashes = collectionDropdown.Current.Value?.Collection?.PerformRead(c => c.BeatmapMD5Hashes).ToList()
};

if (!minimumStars.IsDefault)
Expand Down

0 comments on commit 58992b2

Please sign in to comment.