Merge pull request #25216 from bdach/spinner-tick-lifetime

Fix spinner ticks not playing samples correctly sometimes
ppy · Oct 24, 2023 · bf313cc · bf313cc
2 parents 19be005 + 68397f0
commit bf313cc
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableSpinnerTick.cs b/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableSpinnerTick.cs
@@ -25,6 +25,16 @@ public DrawableSpinnerTick(SpinnerTick spinnerTick)
             Origin = Anchor.Centre;
         }
 
+        protected override void OnApply()
+        {
+            base.OnApply();
+
+            // the tick can be theoretically judged at any point in the spinner's duration,
+            // so it must be alive throughout the spinner's entire lifetime.
+            // this mostly matters for correct sample playback.
+            LifetimeStart = DrawableSpinner.HitObject.StartTime;
+        }
+
         /// <summary>
         /// Apply a judgement result.
         /// </summary>