Add mod search option

[Cootz]

There are already plenty of mods you can play with and it's quite confusing to find them in mod selection. Would be nice to have a search option for this purpose.

[Axilotl17]

sounds bloated. a search bar would not help; it would just make everything more complex.

[peppy]

This is planned.

[bdach]

Do let me know if you're going to try this though, thanks.

[Cootz]

@bdach I'm going to try this. I didn't find any branch with search prototype on your osu fork so I'll create it from scratch

[bdach]

@Cootz if it helps see master...bdach:osu:mod-select-filtering-old. in particular see 2908cec which describes the blocking issues. the ModColumn one is particularly debilitating.

i believe IFilterable is IConditionalFilterable now, but the rest should somewhat work. excluding the blockers, obviously.

i should also emphasise that opening PRs without fixing the blockers mentioned is useless.

[Cootz]

@bdach Thank you for sharing this code, it helped a lot. I fixed ModSelectColumn disappearing from ModSelectOverlay see master...Cootz:osu:add-mod-search-option. I would like you to take a look at it and tell if this workaround can be considered as acceptable?

If no can we consider adding a public SearchContainer.Filter method to osu.framework to manually invoke filtering when we need it?

[bdach]

What you linked is not a good workaround. It's pretty much as ad-hoc as you can get.

I did consider adding a public method to force refiltering but I wasn't sure how it would be received in review. It's still pretty bad but not horribly bad. Try that first I guess.