Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull in all the colors into some class #126

Closed
ddevault opened this issue Nov 4, 2016 · 2 comments
Closed

Pull in all the colors into some class #126

ddevault opened this issue Nov 4, 2016 · 2 comments

Comments

@ddevault
Copy link
Contributor

ddevault commented Nov 4, 2016

Eventually we'll probably let the user override them with skins
@ddevault
Copy link
Contributor Author

Bump

@Tom94
Copy link
Contributor

Tom94 commented Nov 30, 2016

We want more than just the colours to be customizable via skins. It's probably worth it to consider everything that may be customizable, and settle on a solution that is not specific to colours.

What I had in mind was that every class implementing a UI component (e.g. the wedged beatmap info) could get passed in skinned information (e.g. via reflection similar to DI, potentially even using the DI machinery itself) and handle applying the parameters (including colours, position, shape) itself. This would also nicely extend to hit objects.

ddevault added a commit to ddevault/osu that referenced this issue Jan 9, 2017
@ddevault
Add central color class
70ecf48 
I didn't move _every_ color here, but most of them. The ones I left
behind are mostly just shades of gray.

Closes ppy#126
@ddevault ddevault mentioned this issue Jan 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ddevault @Tom94