-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add central color class #286
Conversation
I didn't move _every_ color here, but most of them. The ones I left behind are mostly just shades of gray. Closes ppy#126
BorderThickness = 3, | ||
Children = new[] | ||
{ | ||
new Box | ||
{ | ||
Colour = new Color4(255, 102, 170, 0), | ||
Colour = new Color4(OsuColor.SliderbarNub.R, |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
I don't think it's a good idea to put all colours into a single skin-overridable class. I'd rather make skins be hierarchical instead of just able to edit some global variables. E.g.:
|
There still needs to be a global colour scheme. skins can override at a per-class level if required, but by default it's going to be a shared palette (based on how we implement the default design). |
Which should allow you to change the color palette in the future for skinning purposes.
I didn't move every color here, but most of them. The ones I left behind are mostly just shades of gray.
Closes #126