Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add central color class #286

Merged
merged 4 commits into from
Jan 13, 2017
Merged

Add central color class #286

merged 4 commits into from
Jan 13, 2017

Conversation

ddevault
Copy link
Contributor

@ddevault ddevault commented Jan 9, 2017

I didn't move every color here, but most of them. The ones I left behind are mostly just shades of gray.

Closes #126

I didn't move _every_ color here, but most of them. The ones I left
behind are mostly just shades of gray.

Closes ppy#126
BorderThickness = 3,
Children = new[]
{
new Box
{
Colour = new Color4(255, 102, 170, 0),
Colour = new Color4(OsuColor.SliderbarNub.R,

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@Tom94
Copy link
Contributor

Tom94 commented Jan 10, 2017

I don't think it's a good idea to put all colours into a single skin-overridable class. I'd rather make skins be hierarchical instead of just able to edit some global variables. E.g.:

  • BeatmapInfoWedge
    • Colour = X
    • Anchor = Y
    • Shear = None
    • InitTransform = Start(x0,y0).Delay(z).MoveTo(x1,y1,Elastic)
    • Text
      • Colour = Z
      • FontSize = W

@peppy
Copy link
Sponsor Member

peppy commented Jan 10, 2017

There still needs to be a global colour scheme. skins can override at a per-class level if required, but by default it's going to be a shared palette (based on how we implement the default design).

@peppy peppy merged commit f5f545d into ppy:master Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants