Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod Icons disappearing in results screen #13952

Open
minasminas opened this issue Jul 20, 2021 · 6 comments
Open

Mod Icons disappearing in results screen #13952

minasminas opened this issue Jul 20, 2021 · 6 comments
Labels
area:results priority:2 Moderately important. Relied on by some users or impeding the usability of the game type:cosmetic

Comments

@minasminas
Copy link

When 6 or more mods are used on a single map, the Mod Icons are fading "off-screen" on the smaller panels from other players at the results screen. I guess a solution would be to show every mod after the 4th or 5th one below?

Example (look at the player "SkeletonTM"):

osu_2021-07-20_18-55-01

@bdach
Copy link
Collaborator

bdach commented Jul 20, 2021

I thought there was an issue for this already but I can't find it, so...

@peppy peppy self-assigned this Jul 21, 2021
@peppy peppy added the priority:2 Moderately important. Relied on by some users or impeding the usability of the game label Jul 21, 2021
@peppy
Copy link
Sponsor Member

peppy commented Jul 21, 2021

For the contracted version we can do wrapping to fit quite a few mods (arguably "enough"):

20210721 163510 (dotnet)

But for the expanded panel this may still overflow for some crazy cases. It's not easy to wrap the flow due to there also being a star rating inline, coupled with the fact that there's no spare vertical room to allow it to happen.

@arflyte do you have any ideas for this case?

20210721 163326 (dotnet)

@arflyte
Copy link

arflyte commented Jul 21, 2021

...I'm uh, honestly speechless D:

Will anyone be mad if we limit it to a certain number of mods and put (+number) at the end? It's not informative yes, but we can display it full at performance page.

I'll look into it this Friday.

@smoogipoo
Copy link
Contributor

smoogipoo commented Jul 21, 2021

What you see there is an extreme case that will probably never happen in practice. Because by that point many mods will be limited by mod incompatibilities.

I wouldn't take it to the absolute limit and make concessions for any number of mods - I think it's still possible to show all mods keeping that in mind and just giving them a bit more space for the time being. The reason is to show all mods for people screenshotting to send to their friends.

@arflyte
Copy link

arflyte commented Jul 21, 2021

True. I'll keep that in mind. I might be able to come up with some to solve these extreme cases.

@peppy
Copy link
Sponsor Member

peppy commented Jul 22, 2021

@arflyte I'd probably think of it more in the way that "we don't have any breathing space" on the vertical cards. I don't think this will be the only case we may need to wrap or show one to two lines more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:results priority:2 Moderately important. Relied on by some users or impeding the usability of the game type:cosmetic
Projects
None yet
Development

No branches or pull requests

5 participants