Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starting osu! without an internet connection shows "Missing password" error #24890

Closed
peppy opened this issue Sep 23, 2023 · 4 comments · Fixed by #24897 or #25029
Closed

Starting osu! without an internet connection shows "Missing password" error #24890

peppy opened this issue Sep 23, 2023 · 4 comments · Fixed by #24897 or #25029
Assignees
@peppy
Labels
priority:0 Showstopper. Critical to the next release. type:online

Comments

@peppy
Copy link
Sponsor Member

peppy commented Sep 23, 2023 •
edited

It shouldn't. This must have regressed at some point.

In addition, after this error message appears, the local user session is lost permanently.
@peppy peppy added priority:0 Showstopper. Critical to the next release. type:online labels Sep 23, 2023
@frenzibyte frenzibyte self-assigned this Sep 23, 2023
@frenzibyte
Copy link
Member

I cannot seem to reproduce this. Starting osu! without internet connection puts the API in "failing" state without logging out or showing any errors:

CleanShot 2023-09-24 at 02 35 25@2x

bringing internet connection back shows the client logging back in correctly.

@peppy
Copy link
Sponsor Member Author

peppy commented Sep 24, 2023

If you follow the code, this will only happen when an OAuth refresh is queued. So it's unlikely you will be able to reproduce without trying.

@peppy peppy assigned peppy and unassigned frenzibyte Sep 24, 2023
@peppy peppy mentioned this issue Sep 24, 2023
Merged
@BashhScriptKid
Copy link

The bug still presisted on my end, but I managed to get the log of it

network.log

@peppy
Copy link
Sponsor Member Author

peppy commented Oct 6, 2023 •
edited

Hmm, I feel there was a very good reason I didn't catch SocketExceptions when fixing this issue.. Will have to reinvestigate.

@peppy peppy reopened this Oct 6, 2023
peppy added a commit to peppy/osu that referenced this issue Oct 6, 2023
@peppy
Fix OAuth refresh attempt when no network available causing full logo…
c78b511 
…ut (part 2)

This time for `SocketException`s. I seem to recall looking at this and
deciding there was a reason to not catch socket exceptions, but on
revisiting it seems sane to do so.

This covers a fail case like reported:

```
2023-10-06 03:24:17 [verbose]: Request to https://lazer.ppy.sh/oauth/token failed with System.Net.Http.HttpRequestException: No such host is known. (lazer.ppy.sh:443)
2023-10-06 03:24:17 [verbose]: ---> System.Net.Sockets.SocketException (11001): No such host is known.
2023-10-06 03:24:17 [verbose]: at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
```

Closes ppy#24890 (again).
@peppy peppy mentioned this issue Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peppy peppy

Labels
priority:0 Showstopper. Critical to the next release. type:online
Projects
None yet
Milestone
No milestone
3 participants
@peppy @frenzibyte @BashhScriptKid