Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approach circle doesnt hit the hitcircle on the perfect tap moment on imported skins #27283

Closed
Raregendary opened this issue Feb 21, 2024 · 3 comments · Fixed by #27286
Closed
Assignees
Labels
area:gameplay priority:0 Showstopper. Critical to the next release. ruleset/osu!

Comments

@Raregendary
Copy link

Raregendary commented Feb 21, 2024

Type

Game behaviour

Bug description

In osu lazer with imported skins i have an issue where the perfect timing hit would be when the approach circle is few pixels away from the hitcircle. The issue isn't present in the default skins that are coming with lazer. Also i played the game before in 2021 and it didn't have this issue.

You can literally open a map and when you switch skins live you can see how the hit circle on the classic skin and my imported skins is smaller than the hit circle on the lazer default skins.

Screenshots or videos

The issue was recorded using replay and auto pilot mod not live gameplay.
In the bottom of the screenshot there is a frame indicator.
My imported skin:
1
2

Default osu lazer skin:
3
4

The timing altho not important for this seems to be between + 10-20 ms from playing the game 30 mins and looking at suggested offset, altho its still unreadable.

The following 2 pairs are on 0.5 slowdown instead of 0.05 so if there is a slightly bigger gap it should be ignored due to recording in 60 fps and approach circle is fast :)

The same skin in osu stable doesn't have this issue and its perfectly snapped:
5
6

Older 2021 lazer version around the time i last played it doesn't have said issue:
5
6

First observed issue when lazer pp got released and downloaded the game then.

Version

2024.219.0

Logs

compressed-logs.zip

@Raregendary
Copy link
Author

Raregendary commented Feb 21, 2024

After losing my hearing installing few versions and testing i found that the issue first appeared in 2024.130.2. From 2024.114.0 and before it wasn't.
image

Searching around i see some talk about some 5px padding on hitcircles no idea if that's related or anything
in: osu.Game.Rulesets.Osu/Skinning/Default/DefaultApproachCircle.cs

@peppy peppy added ruleset/osu! area:gameplay priority:0 Showstopper. Critical to the next release. labels Feb 21, 2024
@peppy peppy self-assigned this Feb 21, 2024
@peppy
Copy link
Sponsor Member

peppy commented Feb 21, 2024

@Raregendary attach skin please.

@Raregendary
Copy link
Author

@Raregendary attach skin please.

It happens with all my skins and even the osu classic default skin but i used this skin for all the screenshots:
- # WhiteCat (1.0) 『CK』 #-.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:gameplay priority:0 Showstopper. Critical to the next release. ruleset/osu!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants