Fix LegacyApproachCircle
incorrectly applying scaling factor
#27286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple way of explaining this: it was only supposed to be applied to default skins, but was incorrectly applied everywhere. This was likely an oversight due to the implementation existing in
LegacyApproachCircle
. But it was in theCreateDefault
method which is not used because there's always anapproachcircle
sprite.osu/osu.Game.Rulesets.Osu/Skinning/Legacy/LegacyApproachCircle.cs
Lines 44 to 46 in ad6f04c
Here's the longer version, which I've also updated the inline comment to:
In triangles and argon, we expanded hitcircles to take up the full 128 px which are clickable, but still use the old approach circle sprite. To make it feel correct (ie. disappear as it collides with the hitcircle, not when it overlaps the border) we need to expand it slightly.
This is what the scale adjust exists to do.
Note that this only affects classic and legacy skins.
Closes #27283.