Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing leaderboard data on ranked map #27674

Closed
Riamuw opened this issue Mar 19, 2024 · 2 comments
Closed

Missing leaderboard data on ranked map #27674

Riamuw opened this issue Mar 19, 2024 · 2 comments
Labels
type:online

Comments

@Riamuw
Copy link

Riamuw commented Mar 19, 2024

Type

Game behaviour

Bug description

The map https://osu.ppy.sh/beatmapsets/744883#osu/1613507 Destiny diff has missing leaderboard data even though it is a ranked mapset.

Screenshots or videos

osu_2024-03-19_16-13-43

Version

2024.312.1

Logs

compressed-logs.zip
@bdach
Copy link
Collaborator

bdach commented Mar 20, 2024

This is happening because the difficulty has a different beatmap ID in the .osu file than the one it is actually downloaded from.

Beatmap link is: https://osu.ppy.sh/beatmapsets/744883#osu/1613507
.osu file says: BeatmapID:1570982

Also affects another difficulty in this mapset (https://osu.ppy.sh/beatmapsets/744883#osu/1570982).

I'll add some missing logging but the .osz should probably be fixed? @peppy

bdach added a commit to bdach/osu that referenced this issue Mar 20, 2024
@bdach
Add extended logging when discarding online metadata lookup results
1f343b7 
Related to: ppy#27674

Relevant log output for that particular case:

	[network] 2024-03-20 07:25:30 [verbose]: Performing request osu.Game.Online.API.Requests.GetBeatmapRequest
	[network] 2024-03-20 07:25:30 [verbose]: Request to https://dev.ppy.sh/api/v2/beatmaps/lookup successfully completed!
	[network] 2024-03-20 07:25:30 [verbose]: GetBeatmapRequest finished with response size of 3,170 bytes
	[database] 2024-03-20 07:25:30 [verbose]: [4fe02] [APIBeatmapMetadataSource] Online retrieval mapped Tsukiyama Sae - Hana Saku Iro wa Koi no Gotoshi (Log Off Now) [Destiny] to 744883 / 1613507.
	[database] 2024-03-20 07:25:30 [verbose]: Discarding metadata lookup result due to mismatching online ID (expected: 1570982 actual: 1613507)
	[network] 2024-03-20 07:25:30 [verbose]: Performing request osu.Game.Online.API.Requests.GetBeatmapRequest
	[network] 2024-03-20 07:25:30 [verbose]: Request to https://dev.ppy.sh/api/v2/beatmaps/lookup successfully completed!
	[network] 2024-03-20 07:25:30 [verbose]: GetBeatmapRequest finished with response size of 2,924 bytes
	[database] 2024-03-20 07:25:30 [verbose]: [4fe02] [APIBeatmapMetadataSource] Online retrieval mapped Tsukiyama Sae - Hana Saku Iro wa Koi no Gotoshi (Log Off Now) [Easy] to 744883 / 1570982.
	[database] 2024-03-20 07:25:30 [verbose]: Discarding metadata lookup result due to mismatching online ID (expected: 1613507 actual: 1570982)

Note that the online IDs are swapped.
@bdach bdach mentioned this issue Mar 20, 2024
Merged
@peppy
Copy link
Sponsor Member

peppy commented Apr 10, 2024

I've fixed the beatmap server-side.

@peppy peppy closed this as completed Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:online
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@peppy @bdach @Riamuw