Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loud noises instead of song (Mac OS) #3648

Closed
prismflasher opened this issue Oct 28, 2018 · 23 comments
Closed

Loud noises instead of song (Mac OS) #3648

prismflasher opened this issue Oct 28, 2018 · 23 comments
Assignees
Labels
missing details Can't move forward without more details from the reporter platform/macOS priority:0 Showstopper. Critical to the next release.
Milestone

Comments

@prismflasher
Copy link

I had song select open and had the audio outputting through my laptop's speakers. I switched songs to https://osu.ppy.sh/beatmapsets/26198#osu/88529 and suddenly the sound consisted of loud, glitchy noises rather than the beatmap audio. Playing the beatmap audio from the webpage did not produce these noises. I am running Mac OS 10.13.6 and 2018.1023.0 of Lazer. I don't know if switching beatmaps would've fixed anything, because my first impulse in my panic and fear was to close Osu.
runtime.log
performance.log
network.log
debug.log

@smoogipoo
Copy link
Contributor

Can't replicate here, does it happen a second time around?

@smoogipoo smoogipoo added missing details Can't move forward without more details from the reporter audio platform/macOS labels Oct 29, 2018
@prismflasher
Copy link
Author

prismflasher commented Oct 29, 2018

Hm, I really don't want to try, since my sound (through the external speakers, not through headphones) was broken until I rebooted afterwards, and it really and truly freaked me out since I'm very sensitive to sound. I did remember something that might be relevant, though: I had turned on one of the difficulty mods newly introduced in lazer to try it out, and this happened while I was trying to decide on a song to play through.

@smoogipoo
Copy link
Contributor

Have tried with all of DT, NC, HT and DC mods, all sound fine to me. Can you turn down the sound and test? Or turn off external audio and record it? Hard to determine the nature of the issue without an example...

@prismflasher
Copy link
Author

I tried launching it again and now the app is just flat out crashing on launch. (Looking at the logs from the incident that caused this issue (specifically runtime.log), though, I do notice that it was making some very weird claims about what beatmap was selected. Is that maybe related to the issue?)
(New logs, since it's now crashing on launch:)(I've also saved the crash log generated by the OS, though I'm not entirely certain it's a good idea to post it)
debug.log
network.log
runtime.log

@smoogipoo
Copy link
Contributor

The crash mentioned will be fixed in the next release.

@peppy
Copy link
Sponsor Member

peppy commented Nov 21, 2018

@Mintww could you please report back on how things are in the latest release?

@luaneko
Copy link
Contributor

luaneko commented Dec 27, 2018

I've been able to reproduce this issue since I got a MacBook and it sure freaks the hell out of me every single time. After this happens both internal speakers will be significantly degraded in quality, weakened bass and reduced volume until a full system restart. It does not happen when system volume is set at zero.

It seems to happen mostly when beatmaps are rapidly changed in song select. However the game does not crash.

MacBook Air 2018 with i5 running Mojave and osu!lazer 2018.1219.0

https://streamable.com/ulj7j

runtime.log

@peppy
Copy link
Sponsor Member

peppy commented Dec 27, 2018

Thanks for the video repro, this helps a lot. @Tom94 also mentioned experiencing this. We definitely need to get this resolved ASAP because that's pretty damn scary.

I'm leaning towards this being a bass library level issue as it looks to be bypassing the volume controls completely (which probably rules out a badly initialised audio buffer?)

@peppy peppy added the priority:0 Showstopper. Critical to the next release. label Dec 27, 2018
@smoogipoo smoogipoo added this to the January 2019 milestone Jan 7, 2019
@smoogipoo smoogipoo self-assigned this Jan 7, 2019
@peppy
Copy link
Sponsor Member

peppy commented Jan 7, 2019

@phosphene47 Could you please test the attached dylib (if you can't compile you can just replace the release build's files inside the app bundle)?

On our end it would seem this fixes the bahviour

libbass.dylib.zip

@peppy peppy self-assigned this Jan 7, 2019
@luaneko
Copy link
Contributor

luaneko commented Jan 7, 2019

Nope, this did not fix it. Downloaded the latest build and replaced Contents/MacOS/libbass.dylib with the file you attached unzipped.

Tested on the same machine and the same environment that I specified last time. Reproduced by rapidly alternating beatmapsets in song select. I didn't take a video this time, but I will post one if necessary.

@EmiyaBestBoy
Copy link

Can you elaborate more on full system restart? Do you mean factory reset?

@prismflasher
Copy link
Author

A reboot (rather than just logging out or similar). However, from the issue you were linked from, it looks like a few unlucky people may have their speakers actually fried. If your hardware is fine, turning the computer off and then on again should fix the issue.

(Also, I'm sorry for not reproducing. I couldn't at the time I was prompted to try again and forgot until it had already been reproduced.)

@EmiyaBestBoy
Copy link

Mine looks like it’s permanently fried...
Well time to walk to the Apple Store!
They’ll probably replace it for free I’m still under the 14 days thing.

@peppy
Copy link
Sponsor Member

peppy commented Jan 10, 2019

@Mintww are you on discord? i'd like to throw you some test builds so we can iterate on this quickly.

@peppy
Copy link
Sponsor Member

peppy commented Jan 10, 2019

or @phosphene47 for that matter

@EmiyaBestBoy
Copy link

By the way I was using a MacBook Pro 15 inch 2018.

@peppy
Copy link
Sponsor Member

peppy commented Jan 10, 2019

@Toybonnie1234512341 do you still have the broken machine? if so maybe you can help with some quick testing. else could you please leave feedback on how apple responded for anyone else potentially affected by this?

@EmiyaBestBoy
Copy link

I’m already in the process of returning it so I’m afraid I can’t help.

@peppy
Copy link
Sponsor Member

peppy commented Jan 11, 2019

Could anyone who has confirmed they can test this without damaging hardware please test this build:

https://www.dropbox.com/s/t54pyajvtnejxv0/osu%21-no-fx.app.zip?dl=0

Note: doubletime/halftime will not work

@peppy
Copy link
Sponsor Member

peppy commented Jan 16, 2019

@Mintww @phosphene47 please test if you can.

@peppy peppy removed their assignment Jan 17, 2019
@peppy peppy self-assigned this Jan 17, 2019
@luaneko
Copy link
Contributor

luaneko commented Jan 25, 2019

didn't help. in fact, it gets reproduced immediately on launch before even getting to SongSelect.

@peppy
Copy link
Sponsor Member

peppy commented Jan 31, 2019

@phosphene47 this should be fixed in the new build. please test.

@peppy
Copy link
Sponsor Member

peppy commented Feb 2, 2019

Tentatively closing. Please comment if this still happens post 2019.131.0.

@peppy peppy closed this as completed Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing details Can't move forward without more details from the reporter platform/macOS priority:0 Showstopper. Critical to the next release.
Projects
None yet
Development

No branches or pull requests

5 participants