Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod icons on beatmap leaderboards can overflow past row background #7923

Open
mouzedrift opened this issue Feb 20, 2020 · 4 comments
Open

Mod icons on beatmap leaderboards can overflow past row background #7923

mouzedrift opened this issue Feb 20, 2020 · 4 comments

Comments

@mouzedrift
Copy link
Contributor

Screenshots or videos showing encountered issue:
https://streamable.com/1r75m

osu!lazer version:
commit 0bbc4ab

Beatmap:
https://osu.ppy.sh/beatmapsets/415560#mania/936274

@bdach
Copy link
Collaborator

bdach commented Feb 20, 2020

The video attached looks very wrong overall. The mod icons should not be overflowing past the row background.

@bdach bdach changed the title Mods on beatmap leaderboards don't align correctly with a square resolution when the mirror mod is present Mod icons on beatmap leaderboards can overflow past row background Feb 20, 2020
@mouzedrift
Copy link
Contributor Author

The mod icons should not be overflowing past the row background.

This is only happening when the mirror mod is present though. everything works fine when its not there.

@bdach
Copy link
Collaborator

bdach commented Feb 22, 2020

I've confirmed that this problem has nothing to do with the mirror mod itself. The root cause is the grid container sizings saturating (as in the minimum widths allotted for each columns don't allow the table to shrink any more, so the whole thing just overflows the background).

This is actually a problem web-side too in extreme cases:

image

@Joehuu
Copy link
Member

Joehuu commented Mar 13, 2020

@bdach there's a horizontal scroll bar on the bottom of web's table when it overflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants