Fix duplicate DifficultyControlPoints breaking slider velocities #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… confusing slider velocity calculations
smoogipoo
requested changes
Aug 18, 2017
| @@ -331,6 +332,7 @@ private void handleTimingPoints(Beatmap beatmap, string line) | |||
|
|
|||
| if (speedMultiplier != difficultyPoint.SpeedMultiplier) | |||
| { | |||
| beatmap.ControlPointInfo.DifficultyPoints.RemoveAll(x => x.Time == time); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
smoogipoo
previously approved these changes
Aug 18, 2017
smoogipoo
approved these changes
Aug 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing legacy beatmaps, it was possible to add two
DifficultyControlPoints with different multipliers but the same time. Slider velocity calculation could sometimes take the wrong multiplier, causing the slider ball to move at the wrong speed.Fix is to first remove any difficulty control points with the same time as the one about to be added, so that the latter lines in the file will take priority.
Fixes issue #1014