Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor timeline fixes #1314

Merged
merged 8 commits into from Sep 27, 2017
Merged

Editor timeline fixes #1314

merged 8 commits into from Sep 27, 2017

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Sep 27, 2017

Not sure how it ever worked!

Add(marker = new MarkerVisualisation
{
Colour = colours.Red
});

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

protected void Add(Drawable visualisation) => timeline.Add(visualisation);

protected virtual void LoadBeatmap(WorkingBeatmap beatmap)
{
timeline.Clear();

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@@ -32,22 +32,15 @@ protected TimelinePart()

private void updateRelativeChildSize()
{
if (!Beatmap.Value.TrackLoaded)
// the track may not be loaded completely (only has a length once it is).
if (!Beatmap.Value.Track.IsLoaded)

This comment was marked as off-topic.

@smoogipoo smoogipoo merged commit 415b0b2 into ppy:master Sep 27, 2017
@peppy peppy deleted the fix-invisible-marker branch October 9, 2017 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants