Make beatmap overlay download buttons work #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
naoey
commented
Nov 15, 2017
naoey
commented
- Add noVideo option to DownloadBeatmapSetRequest
- Make Download fire an event with new download instead of returning it
- Add noVideo option to DownloadBeatmapSetRequest - Make Download fire an event with new download instead of returning it
naoey
changed the title
peppy
requested changes
Nov 16, 2017
| @@ -109,6 +103,8 @@ private void load(APIAccess api, BeatmapManager beatmaps, OsuColour colours, Not | |||
|
|
|||
| if (downloadRequest != null) | |||
| attachDownload(downloadRequest); | |||
|
|
|||
| beatmaps.BeatmapDownloadBegan += attachDownload; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| { | ||
| this.api = api; | ||
| this.rulesets = rulesets; | ||
|
|
||
| manager.BeatmapSetAdded += beatmap => |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
- Also unbind event handlers - Remove unused field
naoey
force-pushed
the
beatmap-overlay-download
branch
from
d8aaf81
to
97c5956
Compare
peppy
reviewed
Nov 21, 2017
| private void handleBeatmapAdd(BeatmapSetInfo beatmap) | ||
| { | ||
| if (beatmap.OnlineBeatmapSetID == BeatmapSet.OnlineBeatmapSetID) | ||
| downloadButtonsContainer.FadeOut(transition_duration); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Going to merge this even though the full behaviour I mentioned in my comments isn't yet implemented. @naoey pointed out on discord that he did try to add this and didn't have much luck, so let's leave that for a future PR. |
peppy
approved these changes
Nov 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.