Refresh dropdown appearance & add themed variant to settings sidebar #15070
Conversation
…lable This is to accommodate `SettingsDropdown` usages without an available `OverlayColourProvider`, such as mod settings controls and tournament client usages.
|
While I'm not against this structure, I'm leaning towards just making the bad contrast usages look bad for now or fix them in this PR, rather than make new classes for this. It feels like otherwise we're just going to get further away from the goal of moving everything to colour providers, unless that is seen as an immediate follow-up PR to this. Rationale is that the first thing that stood out here is the menu items having a pitch black caret, which should not be the case. Which means the new class is going to also require an overridden |
|
Sure. I'll look into applying the colours globally and applying local fixes in places where that looks bad, then. |
|
I'll leave the chevron update to you then. Should be anything from a colour provider that isn't black |
|
I've applied the recolouring changes directly to
Colouring changes applied there are educated guesses based on the latest WIP designs for editor and multiplayer. |
|
I've made some changes to the animation of the chevron and background fill just to freshen things up. In the interest of making forward progress, I think this is fine to merge. That said, a next step would be completely ripping out the |
PRing primarily for comment as I'm not sure if the direction will be found agreeable.
Based (somewhat loosely at this point) on the following designs: https://www.figma.com/file/IjrU0u7MFdgmxDofqTlsZb/UI%2FClient-Settings?node-id=0%3A1
2021-10-12.23-56-17.mp4
I say that the updated appearance is based "somewhat loosely" as most of the appearance is unspecified on the design (no hover state, no expanded state, no scrollbar spec). I filled those gaps with what I thought to be my best judgement; the goal was to keep the spirit of the old design but use the new colour palette.
All spacing/layout changes here I consider to be objective improvements and as such they have been applied globally. The more controversial part of this (in my view) is going to be the addition of
ThemedDropdownfor the colouring. The reason why it is a thing is that I tried the simplest thing first - shoving theOverlayColourProviderinto the base controls - but there are places that cache overlay colours and have somewhat transitional colour schemes, and that ended up looking terrible there:Because those cases were mostly transitional as-is anyway, the idea was to have a separate class that opts into the overlay colour scheme, and gradually replace the existing non-themed usages as designs are being updated.
Unfortunately, though, in the end I had to make the
OverlayColourProviderdependency nullable anyway, becauseSettingsItem(which is the only consumer of the themed dropdown) is shared between the settings sidebar, mod settings control, and the tournament client. So at that point I would have either needed to do what I did or needed to add aThemedSettingsItemor whatever. And both options seem just about as bad to me, except the first one is shorter/easier.