Add slider-to-stream conversion operation to osu! editor #15583
Conversation
| public override MenuItem[] ContextMenuItems => new MenuItem[] | ||
| { | ||
| new OsuMenuItem("Add control point", MenuItemType.Standard, () => addControlPoint(rightClickPosition)), | ||
| new OsuMenuItem("Convert to stream", MenuItemType.Destructive, convertToStream), |
There was a problem hiding this comment.
Not sure about this being "destructive" (makes sense from a terminology perspective, but is also very red).
There was a problem hiding this comment.
Yeah, was in two minds about that too. Could see what people say about it, or I could just fix in post.
There was a problem hiding this comment.
Leave for now, if I felt strongly enough I would have already changed it. Maybe "highlighted" or some other in-between accent state works better here, not sure.
There was a problem hiding this comment.
Yeah I agree with "Highlight" better than "Destructive".
There was a problem hiding this comment.
Keep in mind "highlight" is supposed to only be used on one option, where that option is the "normal" path forward. So it probably shouldn't be the answer here.
2021-11-11.23-17-00.mp4
Addresses (closes?) #14246.
All of the above has corresponding test coverage.
I know a stream placement tool was proposed, but I think for proper save/load support that may need to wait for a new beatmap format, otherwise there's no real good way to tell what was a stream after saving to legacy. If waiting for new format is seen as preferable I'll close this.