Split out SkinModelManager from SkinManager
#15791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
previously approved these changes
Nov 25, 2021
peppy
force-pushed
the
realm-integration/skin-model-manager
branch
from
9dcb20a
to
2bfc473
Compare
|
Will need a reapprove here, messed up branches (commit hash unchanged since last review, not sure why actions re-ran). |
1 task
smoogipoo
approved these changes
Nov 25, 2021
smoogipoo
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purely refactoring here.
SkinManagercontains quite a few custom methods - on top of handling imports and model management, it also handled the global current skin and acts as a resource provider for skins - so this helps visually understand which those are.