Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix osu!direct download reloading all panels #1589

Merged
merged 4 commits into from Nov 27, 2017

Conversation

Aergwyn
Copy link
Member

@Aergwyn Aergwyn commented Nov 25, 2017

This fixes the recreation of all panels when a download completes.
Also fixes NullReference when you download without ever opening the details of one Set.
Closes #1570

This fixes the recreation of all panels when a download completes.
Also fixes NullReference when you download without ever opening the details of one Set.
@peppy peppy changed the title fix osu!direct download reloading all panels Fix osu!direct download reloading all panels Nov 26, 2017
@peppy
Copy link
Sponsor Member

peppy commented Nov 26, 2017

I believe we also want to change BeatmapSets to a List or similar. Right now, every time a set is added or removed the enumerable becomes an increasingly complex query (adding one Where to a live LINQ chain each time the events are fired).

At very least, this should be added:

image

@smoogipoo smoogipoo merged commit d20277f into ppy:master Nov 27, 2017
@Aergwyn Aergwyn deleted the fix-reload-all-panels branch November 27, 2017 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

osu!direct should not reload all panels when a download completes
3 participants