Don't show multiplayer channels in chat overlay #16109
Conversation
| channelManager.JoinedChannels.CollectionChanged += joinedChannelsChanged; | ||
|
|
||
| foreach (Channel channel in channelManager.JoinedChannels) | ||
| ChannelTabControl.AddChannel(channel); | ||
| channelManager.JoinedChannels.BindCollectionChanged(joinedChannelsChanged, true); |
There was a problem hiding this comment.
There's no special reason why this was this way. BindCollectionChanged was added after the event.
| @@ -436,12 +433,19 @@ private void joinedChannelsChanged(object sender, NotifyCollectionChangedEventAr | |||
| { | |||
| case NotifyCollectionChangedAction.Add: | |||
| foreach (Channel channel in args.NewItems.Cast<Channel>()) | |||
| ChannelTabControl.AddChannel(channel); | |||
| { | |||
| if (channel.Type != ChannelType.Multiplayer) | |||
There was a problem hiding this comment.
we're gonna want to add spectator here at some point, but i guess that's not relevant until it's implemented.
There was a problem hiding this comment.
Didn't realise we had a spectator type, can be done later. Also, what's a temporary channel?
There was a problem hiding this comment.
I believe it's an unused legacy type. Or maybe it is used but won't be relevant to lazer.
|
Not sure why this comment was removed but I'll repost it here:
It's a good point, but I don't feel comfortable with doing that for the time being, because it seems there's no notion of whether a user has left the channel other than the client explicitly saying they have. For example if the user just Alt+F4s, they'll remain joined to the channel indefinitely:
Can probably be addressed later / if it's a big issue, but I would hope that the new |
|
Was removed because they were watching my stream, where i said something along the lines of: the multiplayer chat display is intended to always be visible (ie. it will be added somewhere on song select / results), which is going to be the intended UX going forward. The global chat won't house the multiplayer/spectator chats, similar to how osu-web also doesn't show these. Bit of a change from how stable does it, but I believe it will be a better flow. |
Resolves #16099