Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of redundant control points displayed on summary timeline #16446

Merged

Commits on Jan 14, 2022

  1. Reduce number of redundant control points displayed on summary timeline

    As pointed out in ppy#16435, beatmaps
    with too many control points (usually added via external automation
    apps) could cause the lazer editor to grind to a halt.
    
    The overheads here are mostly from the GL side. An eventual goal would
    be to render this in a smarter way, rather than using thousands of
    drawables. Until that, this optimisation should help reduce the overhead
    by omitting control points in close proximity that are redundant for
    display purposes.
    
    I've tried to contain this in the display logic directly, with the goal
    that it can be ripped out as fast as it was added. Certainly required
    more changes than I hoped for, but I don't think it's too ugly.
    peppy committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    c64a919 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2022

  1. Configuration menu
    Copy the full SHA
    64c499d View commit details
    Browse the repository at this point in the history
  2. Rename methods and add xmldoc

    peppy committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    c5cae4e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    236fa6d View commit details
    Browse the repository at this point in the history
  4. Fix typo in inline comment

    peppy committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    565611e View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2022

  1. Configuration menu
    Copy the full SHA
    566d341 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2022

  1. Configuration menu
    Copy the full SHA
    93cd07f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    03ac91a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5f5765d View commit details
    Browse the repository at this point in the history