New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce number of redundant control points displayed on summary timeline #16446
Merged
smoogipoo
merged 9 commits into
ppy:master
from
peppy:summary-timeline-control-point-optimisation
Jan 19, 2022
Merged
Reduce number of redundant control points displayed on summary timeline #16446
smoogipoo
merged 9 commits into
ppy:master
from
peppy:summary-timeline-control-point-optimisation
Jan 19, 2022
Commits on Jan 14, 2022
-
Reduce number of redundant control points displayed on summary timeline
As pointed out in ppy#16435, beatmaps with too many control points (usually added via external automation apps) could cause the lazer editor to grind to a halt. The overheads here are mostly from the GL side. An eventual goal would be to render this in a smarter way, rather than using thousands of drawables. Until that, this optimisation should help reduce the overhead by omitting control points in close proximity that are redundant for display purposes. I've tried to contain this in the display logic directly, with the goal that it can be ripped out as fast as it was added. Certainly required more changes than I hoped for, but I don't think it's too ugly.
Configuration menu - View commit details
-
Copy full SHA for c64a919 - Browse repository at this point
Copy the full SHA c64a919View commit details
Commits on Jan 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 64c499d - Browse repository at this point
Copy the full SHA 64c499dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c5cae4e - Browse repository at this point
Copy the full SHA c5cae4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 236fa6d - Browse repository at this point
Copy the full SHA 236fa6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 565611e - Browse repository at this point
Copy the full SHA 565611eView commit details
Commits on Jan 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 566d341 - Browse repository at this point
Copy the full SHA 566d341View commit details
Commits on Jan 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 93cd07f - Browse repository at this point
Copy the full SHA 93cd07fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 03ac91a - Browse repository at this point
Copy the full SHA 03ac91aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f5765d - Browse repository at this point
Copy the full SHA 5f5765dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.