Avoid refetch in RealmLive when operating strictly on the update thread
#16618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
requested changes
Jan 26, 2022
1 task
|
You say "better safeties", but is there something that prompted this? No tests have been added or anything. Put another way, what's "unsafe" about the current implementation and why is that not tested against? |
|
I meant that the reason I closed the previous PR has now been resolved (the re-fetch was sometimes failing due to lack of refresh). See discussion from this post onwards. |
smoogipoo
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt at this (see #16498). Now with better safeties and statistics.
Previous benchmarks still apply.