Remove ruleset and mod bindables from PlaylistItem #16876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
reviewed
Feb 15, 2022
| @@ -117,7 +113,7 @@ public void AddOrUpdateRoom(Room room) | |||
| try | |||
| { | |||
| foreach (var pi in room.Playlist) | |||
| pi.MapObjects(rulesets); | |||
| pi.MapObjects(); | |||
There was a problem hiding this comment.
I guess removing this completely is a follow-up step?
There was a problem hiding this comment.
Correct, it'll be part of the PR removing the beatmap bindable.
peppy
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of my multiplayer model cleanups, aiming to remove all bindables from
PlaylistItem.In this PR, only the
Ruleset,RequiredModsandAllowedModsbindables are removed in favour of storing the raw ruleset ID orAPIMods. Local instances are now constructed on-the-fly in places where they're required.Beatmapis not yet removed because it's part of a more complex change.