Fix user-contracted toolbox groups in editor incorrectly expanding on hover #18120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing container expands
I always found the yellow colour very non-descript in this case. Gray seems to work better?
|
The change makes sense to me. I've fixed code inspections and updated expectations of the test that was covering the old behaviour to match (surprising there was one to begin with, to be quite honest). |
bdach
approved these changes
May 6, 2022
frenzibyte
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This made it nigh-impossible to actually set the state to expanded after contracting once, due to how the
Expandedflag was being managed internally. It also made little sense from a UX perspective - if a user has chosen to hide a toolbox they wouldn't want it to forcefuly expand on hover.I also changed colour denoting expanded state to be gray rather than yellow, as I found the yellow colour very non-descript in this case. Gray seems to work better?