Add drawable channel caching to new chat overlay #18246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzibyte
requested changes
May 13, 2022
|
I can still see some edge-cases with the caching logic (e.g. select channel 1 -> select channel 2 -> select channel 1 back while it's still loading; game freezes until channel 1 finishes loading), but given that this matches the logic in the old overlay, I've added test coverage for the currently working behaviour at least. Looks fine to me, but going to wait for a second review. |
frenzibyte
approved these changes
May 18, 2022
peppy
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #17001
Re-adds caching behaviour present in old overlay