Add key binding to deselect all mods #18264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defaults to `Backspace`.
bdach
reviewed
May 14, 2022
osu.Game.Tests/Visual/UserInterface/TestSceneModSelectOverlay.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
bdach
approved these changes
May 14, 2022
Lawtrohux
added a commit
to Lawtrohux/osu
that referenced
this pull request
May 16, 2022
commit 328561f Merge: 351f5a3 4bb0687 Author: Dean Herbert <pe@ppy.sh> Date: Sun May 15 12:32:20 2022 +0900 Merge pull request ppy#18263 from frenzibyte/spotlight-beatmap-badge Add support for "spotlight" label in beatmap overlay/listing commit 4bb0687 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Sat May 14 21:54:52 2022 +0300 Move badge hierarchy declaration to constructor for safer access commit 351f5a3 Merge: 6e74244 b6575c2 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Sat May 14 20:48:42 2022 +0200 Merge pull request ppy#18264 from peppy/deselect-all-mods-key Add key binding to deselect all mods commit b6575c2 Author: Dean Herbert <pe@ppy.sh> Date: Sun May 15 03:18:44 2022 +0900 Allow selecting all mods at free mod select using `ctrl`+`a` commit 8a01050 Author: Dean Herbert <pe@ppy.sh> Date: Sun May 15 03:16:33 2022 +0900 Refactor mod select button initialisation to allow shared usage of deselect button commit 282c8ae Author: Dean Herbert <pe@ppy.sh> Date: Sun May 15 03:09:15 2022 +0900 Fix typo in test step Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com> commit 1878578 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Sat May 14 21:02:56 2022 +0300 Move todo comment to subclasses commit 441957e Author: Salman Ahmed <frenzibyte@gmail.com> Date: Sat May 14 21:01:29 2022 +0300 Convert get-only virtual properties to avoid DI order dependency commit 88ba84a Author: Salman Ahmed <frenzibyte@gmail.com> Date: Sat May 14 20:52:38 2022 +0300 Replace `Pill` with `Badge` everywhere commit 6c3a437 Author: Dean Herbert <pe@ppy.sh> Date: Sun May 15 02:40:35 2022 +0900 Fix case of "toggle mod select" string commit a759cf2 Author: Dean Herbert <pe@ppy.sh> Date: Sun May 15 02:39:54 2022 +0900 Add key binding to deselect all mods Defaults to `Backspace`. commit 9bac33e Author: Salman Ahmed <frenzibyte@gmail.com> Date: Sat May 14 19:47:29 2022 +0300 Integrate spotlight beatmap badge in listing cards commit 2878a6d Author: Salman Ahmed <frenzibyte@gmail.com> Date: Sat May 14 19:47:10 2022 +0300 Integrate spotlight beatmap badge in info overlay commit 56d6cb5 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Sat May 14 19:46:50 2022 +0300 Add "spotlight" beatmap badge commit c8bea62 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Sat May 14 19:46:34 2022 +0300 Abstractify beatmap badge logic to own class commit d5027cd Author: Salman Ahmed <frenzibyte@gmail.com> Date: Sat May 14 19:46:13 2022 +0300 Add `FeaturedInSpotlight` property to API beatmapsets commit 6e74244 Merge: b533ed5 ab5c736 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Sat May 14 01:04:21 2022 +0200 Merge pull request ppy#18239 from peppy/editor-readability Add lingering hitobject display to editor, replacing "Hit Animations" toggle commit ab5c736 Merge: cf3ead8 b533ed5 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Fri May 13 21:10:48 2022 +0200 Merge branch 'master' into editor-readability commit b533ed5 Merge: 8edbc10 a346456 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Fri May 13 20:42:22 2022 +0200 Merge pull request ppy#18252 from peppy/editor-track-shortcuts Add editor track traversal shortcut keys (`Z`-`V`) commit a346456 Author: Dean Herbert <pe@ppy.sh> Date: Sat May 14 03:01:42 2022 +0900 Add test coverage of new traversal keys commit c4871eb Author: Dean Herbert <pe@ppy.sh> Date: Sat May 14 02:50:51 2022 +0900 Add editor track traversal keys (`Z`-`V`) commit 8edbc10 Merge: 0cf52c4 dec298c Author: Dean Herbert <pe@ppy.sh> Date: Fri May 13 23:13:39 2022 +0900 Merge pull request ppy#18249 from peppy/update-resources Update resources commit cf3ead8 Author: Dean Herbert <pe@ppy.sh> Date: Fri May 13 22:06:30 2022 +0900 Remove unused local commit dec298c Author: Dean Herbert <pe@ppy.sh> Date: Fri May 13 21:47:22 2022 +0900 Update resources commit 35026ad Author: Dean Herbert <pe@ppy.sh> Date: Fri May 13 21:39:54 2022 +0900 Add missing `EditorClock` caching commit d9782b5 Author: Dean Herbert <pe@ppy.sh> Date: Fri May 13 21:31:49 2022 +0900 Remove redundant parenthesis commit 0cf52c4 Merge: 26c8516 4b4f3ec Author: Dean Herbert <pe@ppy.sh> Date: Fri May 13 21:31:17 2022 +0900 Merge pull request ppy#18248 from peppy/add-crowdin-readme Add crowdin information to README commit 38b8baf Author: Dean Herbert <pe@ppy.sh> Date: Fri May 13 21:28:50 2022 +0900 Remove unused border colour commit 1529162 Author: Dean Herbert <pe@ppy.sh> Date: Fri May 13 21:28:45 2022 +0900 Remove circle scaling (apparently the fixed scale is required for spacing) commit 4b4f3ec Author: Dean Herbert <pe@ppy.sh> Date: Fri May 13 19:46:28 2022 +0900 Add crowdin information to README commit ff13ef6 Author: Dean Herbert <pe@ppy.sh> Date: Fri May 13 19:46:21 2022 +0900 Fix a couple of markdown inspections commit 26c8516 Merge: b712742 a35c578 Author: Dean Herbert <pe@ppy.sh> Date: Fri May 13 00:30:13 2022 +0900 Merge pull request ppy#18127 from jai-x/new-chat-drawable-channel Update new chat overlay day separator colours and spacing commit a35c578 Author: Dean Herbert <pe@ppy.sh> Date: Thu May 12 23:54:43 2022 +0900 Resolve colour inline commit 0318944 Author: Dean Herbert <pe@ppy.sh> Date: Thu May 12 23:37:29 2022 +0900 Fix incorrect alive criteria causing clicking future objects to be too greedy commit 51744e4 Merge: 0c33559 b712742 Author: Dean Herbert <pe@ppy.sh> Date: Thu May 12 22:56:55 2022 +0900 Merge branch 'master' into editor-readability commit 8760e5d Merge: 1c63c27 b712742 Author: Dean Herbert <pe@ppy.sh> Date: Thu May 12 22:36:19 2022 +0900 Merge branch 'master' into new-chat-drawable-channel commit 0c33559 Author: Dean Herbert <pe@ppy.sh> Date: Thu May 12 19:42:35 2022 +0900 Tidy up interpolation and move `const` to new home commit f22ff4e Author: Dean Herbert <pe@ppy.sh> Date: Thu May 12 19:28:56 2022 +0900 Remove editor animation toggling (replaced by overlap markers) commit be3d4c9 Author: Dean Herbert <pe@ppy.sh> Date: Thu May 12 19:26:34 2022 +0900 Add circle overlap marker, bringing back stable-like visibility of circles in the past commit c63e65c Author: Dean Herbert <pe@ppy.sh> Date: Thu May 12 19:26:13 2022 +0900 Don't hide `SelectionBlueprint`s themselves, only their children commit 1b2c07e Author: Dean Herbert <pe@ppy.sh> Date: Thu May 12 19:25:51 2022 +0900 Extend lifetime of `OsuSelectionBlueprint` to allow for lingering display commit b712742 Merge: c3d4723 4463a26 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Thu May 12 19:00:21 2022 +0900 Merge pull request ppy#15665 from MBmasher/fl-opacity Consider opacity of hit objects in Flashlight skill commit c3d4723 Merge: b48308e f5649b9 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Thu May 12 18:51:04 2022 +0900 Merge pull request ppy#18237 from peppy/editor-animation-toggle-refresh-immediately Fix toggling hit animations on the editor not applying immediately commit b48308e Merge: 5f2d9bf c4854d4 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Thu May 12 18:42:42 2022 +0900 Merge pull request ppy#18238 from peppy/fix-slider-ball-rotation Fix slider ball rotation becoming undefined when time is not flowing smoothly commit 4463a26 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Thu May 12 17:19:07 2022 +0900 Refactor opacity computation algorithm commit f5649b9 Author: Dean Herbert <pe@ppy.sh> Date: Thu May 12 18:04:20 2022 +0900 Use `AliveObjects` rather than tracking all hitobjects manually commit c4854d4 Author: Dean Herbert <pe@ppy.sh> Date: Thu May 12 17:55:12 2022 +0900 Fix slider ball rotation becoming undefined when time is not flowing smoothly commit 10e41d0 Author: Dean Herbert <pe@ppy.sh> Date: Thu May 12 17:36:35 2022 +0900 Fix toggling hit animations on the editor not applying immediately commit 5f2d9bf Merge: 7ab31b8 3d64dc5 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Thu May 12 15:44:19 2022 +0900 Merge pull request ppy#18211 from frenzibyte/audio-adjustment-breakage-alt Fix mods potentially adjusting track while not selected commit 7ab31b8 Merge: 26d4237 c54ca93 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Thu May 12 15:40:44 2022 +0900 Merge pull request ppy#18234 from peppy/distance-snap-no-snap-to-zero Fix distance snap providing zero-distance snaps incorrectly commit 26d4237 Merge: 678cde3 82c4a5f Author: Dean Herbert <pe@ppy.sh> Date: Thu May 12 15:35:48 2022 +0900 Merge pull request ppy#18181 from jai-x/new-chat-visibility-behaviour Update channel visibilty behaviour in new chat overlay commit 82c4a5f Merge: 6ba0760 678cde3 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Thu May 12 09:04:24 2022 +0300 Merge branch 'master' into new-chat-visibility-behaviour commit c54ca93 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Thu May 12 14:55:20 2022 +0900 Fix CI inspections commit 678cde3 Merge: 4a4f6ab 981ead6 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Thu May 12 14:40:49 2022 +0900 Merge pull request ppy#18230 from bdach/mod-overlay/data-flow-refactor Restructure data flow in mod select overlay commit 3d64dc5 Merge: 9446be2 4a4f6ab Author: Dean Herbert <pe@ppy.sh> Date: Thu May 12 14:18:28 2022 +0900 Merge branch 'master' into audio-adjustment-breakage-alt commit 6ba0760 Merge: 1d38e5b 4a4f6ab Author: Dean Herbert <pe@ppy.sh> Date: Thu May 12 13:59:35 2022 +0900 Merge branch 'master' into new-chat-visibility-behaviour commit 4a4f6ab Merge: effc924 b794deb Author: Dean Herbert <pe@ppy.sh> Date: Thu May 12 13:59:25 2022 +0900 Merge pull request ppy#18218 from peppy/sentry-more-context Add more context to sentry error reports commit 1d38e5b Author: Dean Herbert <pe@ppy.sh> Date: Thu May 12 13:58:10 2022 +0900 Add notes about weird local handling in `ChannelListSelector` commit 2dfed6e Author: Dean Herbert <pe@ppy.sh> Date: Thu May 12 13:53:57 2022 +0900 Remove `selectorActive` bindable completely commit f516075 Author: Dean Herbert <pe@ppy.sh> Date: Thu May 12 13:11:51 2022 +0900 Fix distance snap providing zero-distance snaps incorrectly commit fda6194 Author: Dean Herbert <pe@ppy.sh> Date: Thu May 12 13:04:17 2022 +0900 Update distance snap test when cursor at centre of grid to be in line with expectations commit b794deb Author: Dean Herbert <pe@ppy.sh> Date: Thu May 12 12:06:51 2022 +0900 Add null checks to screen context insertion commit effc924 Merge: d4122f1 9d30b49 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Thu May 12 11:19:13 2022 +0900 Merge pull request ppy#18227 from frenzibyte/fix-results-screen-test-failure Fix intermittent test failures in results screen commit c45e8f6 Author: Jai Sharma <jai@jai.moe> Date: Wed May 11 22:52:25 2022 +0100 Update `ChannelList` test scene commit db371ab Author: Jai Sharma <jai@jai.moe> Date: Wed May 11 22:52:15 2022 +0100 Use `CurrentChannel == null` to show the channel selector commit cced860 Author: Jai Sharma <jai@jai.moe> Date: Wed May 11 22:51:15 2022 +0100 Add `setCurrent` param to `ChannelManager.JoinChannel` commit 981ead6 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed May 11 22:20:00 2022 +0200 Ensure local mods are constructed in time for `Pop{In,Out}()` commit 9353916 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed May 11 21:57:57 2022 +0200 Remove no-longer-necessary guard commit 2266a5c Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed May 11 20:38:53 2022 +0200 Remove no-longer-necessary `ModColumn.Filter` commit 1c01663 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed May 11 20:29:28 2022 +0200 Fix remaining column operations being coupled to drawables commit b5a9f13 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed May 11 20:28:11 2022 +0200 Fix select/deselect all toggle not working correctly after changes commit 52bbce1 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed May 11 20:23:56 2022 +0200 Fix not being able to set `AvailableMods` before loaded commit 7ac6073 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed May 11 20:23:24 2022 +0200 Fix column test scene to work commit fc24a56 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed May 11 19:40:56 2022 +0200 Add protection from recursive updates from external selection commit 83ba06e Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed May 11 19:33:52 2022 +0200 Extract helper property for accessing all mods commit 11ae1da Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed May 11 19:30:06 2022 +0200 Hoist reference replacement logic to overlay level commit 05a21fb Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed May 11 19:02:45 2022 +0200 Hoist `ModState` to overlay level commit e86444c Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed May 11 18:37:31 2022 +0200 Hoist `ModState` to column level commit 74599c9 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed May 11 18:29:14 2022 +0200 Use `ModState` in mod panels commit 478cfc0 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed May 11 18:26:52 2022 +0200 Split model class for mod state commit 315c67a Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed May 11 19:59:30 2022 +0200 Add failing test case for ruleset without all mod types commit 2ddef0e Merge: be09ec8 d4122f1 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Wed May 11 20:29:30 2022 +0300 Merge branch 'master' into sentry-more-context commit d4122f1 Merge: 5585739 ddb2d4e Author: Salman Ahmed <frenzibyte@gmail.com> Date: Wed May 11 20:21:41 2022 +0300 Merge pull request ppy#18228 from bdach/mod-overlay/rename-more Rename remaining references to "mod select screen" nomenclature commit ddb2d4e Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed May 11 18:06:09 2022 +0200 Rename `FreeModSelect{Screen -> Overlay}` reference in inline comment commit 9b7ff9f Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed May 11 18:05:09 2022 +0200 Rename `modSelect{Screen -> Overlay}2` variable commit 62f6caf Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed May 11 18:04:39 2022 +0200 Rename `ModSelect{Screen -> Overlay}` test scenes commit a104277 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed May 11 18:01:33 2022 +0200 Rename `ModSelect{Screen -> Overlay}Strings` commit 9d30b49 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Wed May 11 18:26:04 2022 +0300 Fix intermittent test failures in results screen commit 5585739 Merge: 4531d13 a97986d Author: Dean Herbert <pe@ppy.sh> Date: Wed May 11 22:09:31 2022 +0900 Merge pull request ppy#18225 from peppy/update-libraries Update libraries to latest versions commit a97986d Merge: 3cbd19a 4531d13 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Wed May 11 15:58:45 2022 +0300 Merge branch 'master' into update-libraries commit 3cbd19a Author: Dean Herbert <pe@ppy.sh> Date: Wed May 11 21:17:16 2022 +0900 Update framework commit 4531d13 Merge: 5800d7e a46894b Author: Dean Herbert <pe@ppy.sh> Date: Wed May 11 21:03:44 2022 +0900 Merge pull request ppy#18224 from smoogipoo/ci-improvements Upgrade ReSharper + improve cache busting heuristic commit fecf92e Author: Dean Herbert <pe@ppy.sh> Date: Wed May 11 19:51:22 2022 +0900 Update libraries to latest versions commit 5800d7e Merge: 52c8382 d51689e Author: Dean Herbert <pe@ppy.sh> Date: Wed May 11 19:41:25 2022 +0900 Merge pull request ppy#18220 from frenzibyte/control-popover-focus Focus textbox upon opening control point popovers commit 52c8382 Merge: 55b9d66 d05cd69 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Wed May 11 18:43:55 2022 +0900 Merge pull request ppy#18221 from peppy/multiplayer-leaderboard-hiding Change multiplayer leaderboard to always hide during gameplay unless holding-for-HUD commit a46894b Author: Dan Balasescu <smoogipoo@smgi.me> Date: Wed May 11 18:27:57 2022 +0900 Bust CI cache on more files commit 551370d Author: Dan Balasescu <smoogipoo@smgi.me> Date: Wed May 11 18:26:08 2022 +0900 Update ReSharper package commit d51689e Author: Salman Ahmed <frenzibyte@gmail.com> Date: Wed May 11 11:25:41 2022 +0300 Unfocus textbox when dismissing popover in test scene commit 55b9d66 Merge: 396be1b 0b597e7 Author: Dean Herbert <pe@ppy.sh> Date: Wed May 11 16:40:52 2022 +0900 Merge pull request ppy#18219 from frenzibyte/fix-timeline-breakage Fix timeline not handling mouse down events commit d05cd69 Author: Dean Herbert <pe@ppy.sh> Date: Wed May 11 16:12:54 2022 +0900 Change multiplayer leaderboard to always hide during gameplay unless holding-for-HUD commit 1c36995 Author: Dean Herbert <pe@ppy.sh> Date: Wed May 11 16:09:16 2022 +0900 Expose `HoldingForHUD` state from `HUDOverlay` as bindable commit 96db530 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Wed May 11 09:55:34 2022 +0300 Focus textbox on control point popovers commit 24432df Author: Salman Ahmed <frenzibyte@gmail.com> Date: Wed May 11 09:53:04 2022 +0300 Add support for focusing intermediate slider-textbox component commit f797514 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Wed May 11 09:51:59 2022 +0300 Add failing test cases commit e43ce28 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Wed May 11 09:51:00 2022 +0300 Remove references of "difficulty point" in sample point test scene Fat-fingered. commit 0b597e7 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Wed May 11 09:39:27 2022 +0300 Fix timeline not handling mouse down events commit 396be1b Merge: c61d0ff 533f4b2 Author: Dean Herbert <pe@ppy.sh> Date: Wed May 11 15:05:20 2022 +0900 Merge pull request ppy#18216 from peppy/sentry-build-suffix Remove build suffix from version when reporting to sentry commit be09ec8 Author: Dean Herbert <pe@ppy.sh> Date: Wed May 11 14:52:08 2022 +0900 Add global statistics context to sentry commit f53d42d Author: Dean Herbert <pe@ppy.sh> Date: Wed May 11 14:51:56 2022 +0900 Add realm context to sentry commit 977a045 Author: Dean Herbert <pe@ppy.sh> Date: Wed May 11 14:11:20 2022 +0900 Add beatmap context to sentry commit b136677 Author: Dean Herbert <pe@ppy.sh> Date: Wed May 11 14:03:16 2022 +0900 Add config and clock time contexts to sentry commit 843e13a Author: Dean Herbert <pe@ppy.sh> Date: Wed May 11 12:55:15 2022 +0900 Add screen stack context to sentry commit 533f4b2 Author: Dean Herbert <pe@ppy.sh> Date: Wed May 11 10:40:40 2022 +0900 Add explanation inline for future visitors commit 9dce329 Author: Dean Herbert <pe@ppy.sh> Date: Wed May 11 10:38:35 2022 +0900 Remove build suffix from version when reporting to sentry commit c61d0ff Merge: dd316be 5325925 Author: Dean Herbert <pe@ppy.sh> Date: Wed May 11 10:27:57 2022 +0900 Merge pull request ppy#18215 from bdach/mod-overlay/rename-new Rename new mod select classes to "mod overlay" nomenclature commit 5325925 Merge: 76c63f1 dd316be Author: Dean Herbert <pe@ppy.sh> Date: Wed May 11 10:15:59 2022 +0900 Merge branch 'master' into mod-overlay/rename-new commit dd316be Merge: 7473ff4 c4c7556 Author: Dean Herbert <pe@ppy.sh> Date: Wed May 11 10:09:42 2022 +0900 Merge pull request ppy#18214 from bdach/mod-overlay/delete-old Remove old mod overlay code commit 7473ff4 Merge: 587cc8c ec231e0 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Wed May 11 09:53:46 2022 +0900 Merge pull request ppy#18210 from peppy/realm-asycn-import-woes Fix realm refetch operations potentially being unsafe commit 76c63f1 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Tue May 10 22:29:57 2022 +0200 Rename `ModSelect{Screen -> Overlay}` in place of removed old design commit c4c7556 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Tue May 10 22:07:24 2022 +0200 Make remains of `TestSceneModSettings` non-visual As they're not really testing anything visual. commit 33634cb Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Tue May 10 21:58:22 2022 +0200 Remove old mod buttons commit 8b0ece1 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Tue May 10 21:55:54 2022 +0200 Remove old mod section commit dfd9770 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Tue May 10 21:53:42 2022 +0200 Remove old mod settings container & related controls commit 128468e Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Tue May 10 21:52:30 2022 +0200 Remove old base mod select overlay commit 24c59e2 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Tue May 10 21:48:21 2022 +0200 Remove old user mod select overlay commit 4a3447f Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Tue May 10 21:45:57 2022 +0200 Remove old free mod select overlay commit 9cfe2cc Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Tue May 10 21:43:57 2022 +0200 Move `TestCustomisableModRuleset` out of `TestSceneModSettings` commit 9446be2 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Tue May 10 20:49:15 2022 +0300 Remove unnecessary `UnbindAdjustments` call It is not necessary given that `CurrentTrack` already removes all adjustments first. commit 36a7644 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Tue May 10 20:46:31 2022 +0300 Reinstantiate mod adjustments layer for safety against previous mods commit a0f1c48 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Tue May 10 19:24:36 2022 +0300 Fix `ModTimeRampTest` failing due to changes in `Update` method commit ec231e0 Author: Dean Herbert <pe@ppy.sh> Date: Wed May 11 00:45:17 2022 +0900 Use more local realm reference Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com> commit 725ff93 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Tue May 10 18:02:32 2022 +0300 Define local adjustments component for mods in `MusicController` Isolates `CurrentTrack` from being directly adjusted by the mod, which could lead to issues depending on how the mod adds adjustments (i.e. `ModTimeRamp`, which adds adjustments based on changes to a setting bindable). commit 82b784c Author: Salman Ahmed <frenzibyte@gmail.com> Date: Tue May 10 18:01:36 2022 +0300 Change `IApplicableToSample` to receive adjustable component instead Done for consistency with `IApplicableToTrack`. commit 4f50017 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Tue May 10 18:01:15 2022 +0300 Change `IApplicableToTrack` to receive adjustable component instead commit bbbecbb Author: Salman Ahmed <frenzibyte@gmail.com> Date: Tue May 10 17:54:34 2022 +0300 Apply time-ramping adjustment using clock instead of track commit 0eb29d5 Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 19:46:55 2022 +0900 Rename new test method to be english commit 587cc8c Merge: 2e774fb b2a57c3 Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 21:57:15 2022 +0900 Merge pull request ppy#18204 from frenzibyte/move-soft-handle-exception commit 33f0242 Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 20:47:26 2022 +0900 Fix realm refetch operations potentially being unsafe As seen in test failure https://github.com/ppy/osu/runs/6357384721?check_suite_focus=true. commit 87f6f74 Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 21:03:55 2022 +0900 Add failing test coverage of adding a file to a detached beatmap across threads commit 2e774fb Merge: 09613c9 42fe708 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Tue May 10 20:31:33 2022 +0900 Merge pull request ppy#18207 from peppy/first-run-finalise Improve first run overlay layout (and switch on) commit 42fe708 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Tue May 10 19:56:21 2022 +0900 Fix inspection commit b2a57c3 Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 19:10:34 2022 +0900 Move implementation to base commit 4d22f26 Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 19:07:07 2022 +0900 Rename property and improve xmldoc commit cac6d55 Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 19:07:00 2022 +0900 Fix incorrect variable reference in log output commit a578f7a Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 18:08:17 2022 +0900 Force nested screens to load synchronously commit a93c63b Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 18:04:10 2022 +0900 Add loading spinner when loading first run screens commit 25c6226 Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 17:47:04 2022 +0900 Adjust transition length for a more seamless screen change commit 493798a Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 17:44:23 2022 +0900 Fix nested ui scale example screens no longer fitting commit 63b9e01 Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 17:35:43 2022 +0900 Fix behaviour screen using old style buttons commit 61313b6 Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 17:33:37 2022 +0900 Standardise font sizes in first run overlay screens commit e5204e5 Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 17:23:12 2022 +0900 Move horizontal padding to content level to better align scrollbar commit bcce9c5 Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 17:01:36 2022 +0900 Limit the width of first run overlay content commit 9aadc27 Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 16:43:38 2022 +0900 Show first run dialog on first run of the game commit 09613c9 Merge: a6674d8 14a21e9 Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 18:12:50 2022 +0900 Merge pull request ppy#18206 from frenzibyte/fix-first-run-hot-reload Workaround interface mocks in `TestSceneFirstRunSetupOverlay` breaking with hot reload commit 14a21e9 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Tue May 10 11:41:41 2022 +0300 Workaround interface mocks in `TestSceneFirstRunSetupOverlay` breaking with hot reload commit a6674d8 Merge: 5af18f9 6a49eb6 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Tue May 10 17:11:36 2022 +0900 Merge pull request ppy#18205 from peppy/sentry-setup Bring sentry usage up-to-date commit 5af18f9 Merge: 886a481 8ccf2ee Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 16:26:57 2022 +0900 Merge pull request ppy#18202 from smoogipoo/workaround-freemod-performance Workaround bad performance when selecting all freemods commit 6a49eb6 Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 16:14:04 2022 +0900 Add breadcrumb level mappings commit 216c68e Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 15:19:43 2022 +0900 Add unobserved exception hinting commit 363643a Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 15:08:49 2022 +0900 Remove sentry logger debounce This is probably going to result in a high quantity of exceptions, but I think this is fine. We can add rules as we go to not log certain exception types. commit c6112b3 Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 15:07:02 2022 +0900 Add unhandled exception marking commit 99e6d56 Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 14:45:55 2022 +0900 Add finalizer to sentry logger for safety commit 9734d77 Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 14:44:54 2022 +0900 Update sentry SDK usage in line with more recent specifications commit 3338bff Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 14:25:10 2022 +0900 Attach user to sentry later in startup flow commit a5b454e Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 14:21:49 2022 +0900 Remove unnecessary DI caching of `SentryLogger` commit 64cc6eb Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 14:12:31 2022 +0900 Add local user tracking to sentry reporting commit 09c21cd Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 14:08:42 2022 +0900 Add log level translation commit dc3c73f Author: Dean Herbert <pe@ppy.sh> Date: Tue May 10 14:03:03 2022 +0900 Enable sentry session tracking commit 725f5f4 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Tue May 10 10:02:41 2022 +0300 Allow one more exception per second in `OsuGame` and `TournamentGame` commit bcd91ac Author: Salman Ahmed <frenzibyte@gmail.com> Date: Tue May 10 10:02:32 2022 +0300 Move exception soft-handling logic to `OsuGameBase` commit 8ccf2ee Author: Dan Balasescu <smoogipoo@smgi.me> Date: Tue May 10 15:07:08 2022 +0900 Add inline comment commit 2b7eead Author: Dan Balasescu <smoogipoo@smgi.me> Date: Tue May 10 14:48:41 2022 +0900 Workaround bad performance when selecting all freemods commit 886a481 Merge: 8a559ff beb86a7 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Tue May 10 13:48:02 2022 +0900 Merge pull request ppy#18180 from frenzibyte/fix-toolbox-double-tap Fix `SettingsToolboxGroup` not clearing transforms before updating autosize commit 8a559ff Merge: 5b17e92 5726cf6 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Tue May 10 12:14:10 2022 +0900 Merge pull request ppy#18191 from frenzibyte/button-use-overlay-colour Fix buttons no longer coloured using `OverlayColourProvider` commit 2481201 Author: Jai Sharma <jai@jai.moe> Date: Mon May 9 22:58:46 2022 +0100 Fix selector dismissal behaviour during user actions commit beb86a7 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Mon May 9 23:57:08 2022 +0300 Remove usage of player settings in `TestSceneSettingsToolboxGroup` commit 96ea4ee Author: Salman Ahmed <frenzibyte@gmail.com> Date: Mon May 9 23:49:05 2022 +0300 Add explanatory comment commit 38e463d Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Mon May 9 22:16:04 2022 +0200 Add failing test case for invalid mod adjustment management commit ebb64d1 Author: Jai Sharma <jai@jai.moe> Date: Mon May 9 20:15:43 2022 +0100 Use `AddUntilStep` to wait for channel to load and become visible commit 5726cf6 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Mon May 9 21:19:34 2022 +0300 Improve test coverage to use existing `ThemeComparisonTestScene` commit 1fcfeac Author: Salman Ahmed <frenzibyte@gmail.com> Date: Mon May 9 18:52:09 2022 +0300 Fix `RoundedButton` not using its default background colour commit ace25af Author: Salman Ahmed <frenzibyte@gmail.com> Date: Mon May 9 20:55:26 2022 +0300 Revert "Move default background colour specification to `OsuButton`" This reverts commit 172524f. commit 172524f Author: Salman Ahmed <frenzibyte@gmail.com> Date: Mon May 9 18:21:00 2022 +0300 Move default background colour specification to `OsuButton` commit ceb6276 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Mon May 9 18:19:29 2022 +0300 Add failing test case commit d4cc2bd Author: Jai Sharma <jai@jai.moe> Date: Mon May 9 12:01:30 2022 +0100 Ensure channel selector is dismissed when the current channel is changed commit 9ec8b60 Author: Jai Sharma <jai@jai.moe> Date: Mon May 9 12:00:49 2022 +0100 Update channel visibility tests to be more correct commit 5f3bea8 Author: Jai Sharma <jai@jai.moe> Date: Mon May 9 11:15:12 2022 +0100 Simplify fetching of `DrawableChannel` commit 702c6ae Author: Salman Ahmed <frenzibyte@gmail.com> Date: Mon May 9 13:49:31 2022 +0300 Fix `SettingsToolboxGroup` not clearing transforms before updating autosize commit deda1c8 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Mon May 9 13:44:18 2022 +0300 Add failing test case commit 0fe121f Author: Salman Ahmed <frenzibyte@gmail.com> Date: Mon May 9 13:25:22 2022 +0300 Move and rename settings toolbox group test scene commit 1c63c27 Merge: 623e2c9 ab1d46b Author: Dean Herbert <pe@ppy.sh> Date: Mon May 9 18:23:00 2022 +0900 Merge branch 'master' into new-chat-drawable-channel commit 623e2c9 Author: Jai Sharma <jai@jai.moe> Date: Mon May 9 00:32:22 2022 +0100 Adjust padding commit aeb2984 Author: Jai Sharma <jai@jai.moe> Date: Mon May 9 00:29:40 2022 +0100 Move `ChatOverlayDrawableChannel` to it's own file commit c221058 Author: Jai Sharma <jai@jai.moe> Date: Mon May 9 00:26:00 2022 +0100 Simplify fetching `DrawableChannel` in `ChatOverlayV2` test commit 5f80e34 Author: Jai Sharma <jai@jai.moe> Date: Mon May 9 00:15:08 2022 +0100 Update day separator date text to right align against username commit 8da7bbd Author: Jai Sharma <jai@jai.moe> Date: Sat May 7 23:30:46 2022 +0100 Code quality commit c0643ca Author: Jai Sharma <jai@jai.moe> Date: Sat May 7 23:24:34 2022 +0100 Create `ChatOverlayDaySeparator` and use in `ChatOverlayDrawableChannel` commit f4acfbd Author: Jai Sharma <jai@jai.moe> Date: Sat May 7 22:23:46 2022 +0100 Change return type of `CreateDaySeparator` to `Drawable` commit bec28c5 Author: Jai Sharma <jai@jai.moe> Date: Sat May 7 22:16:11 2022 +0100 Remove virtual `ColourInfo` properties from `DaySeparator` commit 6fc808b Author: Jai Sharma <jai@jai.moe> Date: Fri May 6 23:17:59 2022 +0100 Code quality commit 9d62206 Author: Jai Sharma <jai@jai.moe> Date: Fri May 6 22:56:35 2022 +0100 Update new chat overlay day separator colours and spacing Updates the `DaySeparator` component to have separately settable colours for the text and the lines. Updates existing overrides of the `DaySeparator` to use the new colour setter. Create new `ChatOverlayDrawableChannel` with adjusted spacing and new `DaySeparator` colours. commit ce095d6 Merge: 36d1cdb b19e738 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Tue Apr 26 18:34:53 2022 +0900 Merge branch 'master' into fl-opacity commit 36d1cdb Merge: 2aafcd3 4b127d5 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Thu Jan 20 14:48:20 2022 +0900 Merge branch 'master' into fl-opacity commit 2aafcd3 Author: MBmasher <mbmasher@gmail.com> Date: Tue Dec 21 20:58:05 2021 +1100 Refactor code regarding `hidden` boolean commit c5de203 Author: MBmasher <mbmasher@gmail.com> Date: Tue Dec 21 20:10:19 2021 +1100 Multiply `opacityBonus` to base strain commit 5d89684 Author: MBmasher <mbmasher@gmail.com> Date: Tue Dec 21 20:08:57 2021 +1100 Adjust `skillMultiplier` after merging ppy#15728, ppy#15867 commit 3d3de00 Author: MBmasher <mbmasher@gmail.com> Date: Tue Dec 21 20:06:53 2021 +1100 Move `hidden` initialisation to Flashlight constructor commit a7aea49 Author: MBmasher <mbmasher@gmail.com> Date: Tue Dec 21 20:06:07 2021 +1100 Rename `osuPreviousHitObject` to `currentHitObject` commit 0a33f33 Merge: 9824d80 4ba5a93 Author: MBmasher <38526268+MBmasher@users.noreply.github.com> Date: Tue Dec 21 19:48:49 2021 +1100 Merge branch 'master' into fl-opacity commit 9824d80 Author: MBmasher <mbmasher@gmail.com> Date: Tue Nov 30 14:36:38 2021 +1100 Remove unnecessary clockRate in Opacity function commit 5884b05 Author: MBmasher <mbmasher@gmail.com> Date: Tue Nov 30 13:54:41 2021 +1100 Add blank line commit 3339afd Author: MBmasher <mbmasher@gmail.com> Date: Tue Nov 30 13:52:58 2021 +1100 Change input variable name in Opacity function commit b0dc8bf Author: MBmasher <mbmasher@gmail.com> Date: Tue Nov 30 12:58:49 2021 +1100 Change Opacity function to take in absolute map time rather than relative time commit 383bf7c Author: Dan Balasescu <smoogipoo@smgi.me> Date: Tue Nov 30 10:39:48 2021 +0900 Only allow HD combination alongside FL commit e6e6e2d Merge: 65ef030 823552a Author: Dan Balasescu <smoogipoo@smgi.me> Date: Tue Nov 30 10:00:44 2021 +0900 Merge branch 'master' into fl-opacity commit 65ef030 Author: MBmasher <mbmasher@gmail.com> Date: Mon Nov 22 08:59:41 2021 +1100 Further balancing commit 7833fab Author: MBmasher <mbmasher@gmail.com> Date: Mon Nov 22 08:41:56 2021 +1100 Balancing bonuses to adjust for corrected opacity formula commit e9745a3 Author: MBmasher <mbmasher@gmail.com> Date: Mon Nov 22 08:32:35 2021 +1100 Fix wrong opacity formula commit e9a4ee6 Author: MBmasher <mbmasher@gmail.com> Date: Sun Nov 21 23:53:40 2021 +1100 Cleaning up code commit a57c277 Author: MBmasher <mbmasher@gmail.com> Date: Sun Nov 21 23:43:09 2021 +1100 Move preempt back to CreateDifficultyAttributes commit afbec94 Author: MBmasher <mbmasher@gmail.com> Date: Sun Nov 21 23:40:15 2021 +1100 Move opacity function to OsuDifficultyHitObject commit fe83b8f Author: MBmasher <mbmasher@gmail.com> Date: Thu Nov 18 10:50:32 2021 +1100 Add line break commit f4b23f0 Author: MBmasher <mbmasher@gmail.com> Date: Thu Nov 18 10:37:07 2021 +1100 Remove setting preempt in CreateDifficultyAttributes commit 30e18f1 Author: MBmasher <mbmasher@gmail.com> Date: Thu Nov 18 10:33:44 2021 +1100 Change mods and preemptTime to readonly commit 92cf447 Author: MBmasher <mbmasher@gmail.com> Date: Thu Nov 18 10:32:41 2021 +1100 Remove unnecessary braces commit 8e85715 Author: MBmasher <mbmasher@gmail.com> Date: Thu Nov 18 09:48:18 2021 +1100 Removing unnecessary file commit 6a444b9 Author: MBmasher <mbmasher@gmail.com> Date: Thu Nov 18 09:47:41 2021 +1100 Further balancing opacity/hidden bonus commit 63c5f7d Author: MBmasher <mbmasher@gmail.com> Date: Wed Nov 17 11:39:12 2021 +1100 Balancing opacity and hidden bonus commit f2d05ea Author: MBmasher <mbmasher@gmail.com> Date: Wed Nov 17 11:27:48 2021 +1100 Remove strain being multiplied by max opacity bonus commit efac11e Author: MBmasher <mbmasher@gmail.com> Date: Fri Nov 12 21:42:27 2021 +1100 Add extra bonus for hidden+flashlight commit 5a3be77 Author: MBmasher <mbmasher@gmail.com> Date: Fri Nov 12 21:41:01 2021 +1100 Resolve conflicts with recent slider hotfix commit 131e64e Author: MBmasher <mbmasher@gmail.com> Date: Fri Nov 12 21:29:51 2021 +1100 Add bonus based on opacity of hit objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18235.
Not sure about a key binding to select all. Should probably just use the platform action if anything.
Defaults to
Backspace.