Adjust menu cursor rotation to use a floating centre-point #18841
Conversation
| var position = e.MousePosition; | ||
| float distance = Vector2Extensions.Distance(position, positionMouseDown); | ||
|
|
||
| // don't start rotating until we're moved a minimum distance away from the mouse down location, | ||
| // else it can have an annoying effect. | ||
| if (dragRotationState == DragRotationState.DragStarted && distance > 30) | ||
| if (dragRotationState == DragRotationState.DragStarted && distance > 80) |
There was a problem hiding this comment.
I feel the new distance threshold is a bit aggressive. It allows the cursor to not rotate when moving/spinning in small distances, but is also causing the rotation to no longer occur when dragging near elements around:
CleanShot.2022-06-25.at.14.21.30.mp4
I think going with 50 is sort of a middle-ground solution (along with updating the mouse down position interpolating logic to something like 30-40), but that depends on whether the rotation is meant to be used for such scenarios.
Could instead add a special case for dragged drawables that would switch the cursor to "rotation" mode regardless of distance.
| if (dragRotationState == DragRotationState.DragStarted && distance > 80) | |
| if (dragRotationState == DragRotationState.DragStarted && distance > 50) |
There was a problem hiding this comment.
I intentionally wanted it to invoke less. Will wait for more feedback.
There was a problem hiding this comment.
I think it feels better this way.
There was a problem hiding this comment.
I know this is pretty old at this point but I went to make a discussion about this exact change thinking it was a bug and found this PR. I really enjoyed dragging the cursor in circles while I was deciding what map to play, doing it absentmindedly, or for the fun of it. It kinda blows I have to intentionally shake the mouse around a bunch to make it happen now. Can this be undone or just happen when dragging something on a list?
There was a problem hiding this comment.
It shouldn't take much effort to enter this mode. You don't need to shake or anything. It's just velocity based.
Been bugging me for a while. Adjusted snappiness of animations and fixed centre point being stuck at original mouse down location.