Fix playlist room creation screen pushing content on opening dropdowns #19065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzibyte
changed the title
|
In the future please submit PRs off topic branches rather than your fork's |
|
As for the actual code, looks simple enough as this is reusing the same workaround that multiplayer dropdowns use. I did find this one masking quirk: 2022-07-11.21-31-27.mp4But I'm not super sure it matters too much and the multiplayer dropdowns do the same thing, so probably fine to ignore? |
bdach
approved these changes
Jul 11, 2022
smoogipoo
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes duration dropdown menu on playlist creation screen so that it does NOT push the content below down as discussed in issue #18162 by copying the solution in multiplayer creation screen.