Fix mania star rating varying by order of notes in a chord #19120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abraker95
reviewed
Jul 14, 2022
The test beatmap linked in the original issue and my own testing beatmaps all seem to be fixed with this change, including one where the anchor is the thing that changes between maps. |
|
I'm not knowledgeable enough regarding the code side of things so I will not comment on that part, but the bug being fixed is important since this was highly exploitable in terms of SR bloating. Planning to accept anyway but would love to see a detailed explanation of why the bug was happening and how this solves it in a way we're not encurring in any unwanted SR buffs/nerfs or side-effects in chord-heavy maps |
smoogipoo
reviewed
Aug 15, 2022
|
SR/PP change sheet added to OP. |
smoogipoo
changed the title
1 task
Kominaru
approved these changes
Aug 17, 2022
This was referenced Aug 21, 2022
This was referenced Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4010.
This change targets notes in chords by giving them the maximum
individualStrainscolumn for notes in that chord. Also comes with some refactoring to clean up the code a little.Note: As I was fixing this change, an unrelated bug with the first note not counting to
individualStraincauses a very similar looking issue on some very short maps (<10 seconds). I was planning to include it in this PR but because the effect is quite minor I thought it would be best to leave that for another day.SR/PP change spreadsheet: https://docs.google.com/spreadsheets/d/1VQlT253Cf_SCFNrBF1MI9oAlX5MA_i98HEdf4BulsZc/edit
As of b33e0f5