Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star Rating varies based on same beat note order placed in Mania #4010

Closed
nbayt opened this issue Jan 8, 2019 · 1 comment · Fixed by #19120
Closed

Star Rating varies based on same beat note order placed in Mania #4010

nbayt opened this issue Jan 8, 2019 · 1 comment · Fixed by #19120

Comments

@nbayt
Copy link

nbayt commented Jan 8, 2019

Describe your problem: Star rating of a song can be boosted by reordering notes that share the same time.

Screenshots or videos showing encountered issue: capture
In the above image both songs are identical, the only difference is that the order the notes were placed on each downbeat is different.
Lazer will give the one on the left a rating of 1.66 and the other 1.86 (Stable is 1.71 and 1.66 respectively.)

osu!lazer version: 2018:1228.0

Logs:
database.log
network.log
performance.log
runtime.log

Here is the .osu file.
Broken Chords (Camellia - flying in the flow of deep-sea).zip

Possible solution would be to add a check when we see a note on the same beat top check last keycount notes. Here is some thing I drafted up in python that does the trick (poorly).

# Make notes that fall on the same beat have the same overall_strain. self.max_beat_overall_strain=self.overall_strain if self.note.start==_previous_note.note.start: self.max_beat_overall_strain=max(self.max_beat_overall_strain, _previous_note.max_beat_overall_strain) # NOT EFFICIENT!!! for i in range(len(self.prior_notes)): if not self.prior_notes[i] is None and self.prior_notes[i].note.start == self.note.start: self.prior_notes[i].overall_strain=self.max_beat_overall_strain

@smoogipoo
Copy link
Contributor

The bigger issue here is that diffcalc is not invariant to sorting order.

nbayt added a commit to nbayt/osu that referenced this issue Jan 10, 2019
Fixes: ppy#4010
Notes sharing the same start time will now have the same overall
difficulty.
@peppy peppy added this to the Candidate Issues milestone Jan 15, 2019
@peppy peppy removed the bug label Dec 20, 2019
@peppy peppy modified the milestone: Candidate Issues Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants