Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A lot of fixes to replay playback #1923

Merged
merged 11 commits into from Jan 17, 2018
Merged

A lot of fixes to replay playback #1923

merged 11 commits into from Jan 17, 2018

Conversation

smoogipoo
Copy link
Contributor

Fixes:

  • Replays not getting loaded when dragged in.
    • The BeatmapSet Files weren't populated through BeatmapManager.QueryBeatmap.
    • I don't know whether this is the best fix for this, but this (and similar) functions are only used here and in a testcase, so it's not going to cause any performance issues.
  • Replays being offset.
    • Negative-time frame offsets weren't considered.
    • Although I don't know how this is possible, I do remember it being a thing for a very long time and still continues to be a thing with recent replays.
  • ReplayPlayer not giving us the replay UI and not allowing timeline scrolling.
    • Wasn't being treated as actually having a replay due to it setting the replay in LoadComplete().
  • ResultsScreen displaying the wrong user for replays loaded through the ScoreStore.

@smoogipoo smoogipoo added this to the January 2018 milestone Jan 17, 2018
thomastanck
thomastanck reviewed Jan 17, 2018
View reviewed changes
osu.Game/Rulesets/Scoring/ScoreStore.cs Outdated
@@ -141,7 +149,7 @@ private Replay createLegacyReplay(StreamReader reader)
));
}

return new Replay { Frames = frames };
return new Replay { Frames = frames.OrderBy(f => f.Time).ToList() };

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

peppy
peppy requested changes Jan 17, 2018
View reviewed changes
osu.Game/Screens/Play/SongProgress.cs Outdated
public void BindRulestContainer(RulesetContainer rulesetContainer)
{
replayLoaded.BindTo(rulesetContainer.HasReplayLoaded);
replayLoaded.TriggerChange();

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@peppy
Copy link
Sponsor Member

peppy commented Jan 17, 2018

Looks good otherwise 👍

peppy
peppy reviewed Jan 17, 2018
View reviewed changes
osu.Game/Screens/Play/SongProgress.cs Outdated
@@ -93,11 +98,21 @@ public SongProgress()
OnSeek = position => OnSeek?.Invoke(position),
},
};

replayLoaded.ValueChanged += v => AllowSeeking = v;

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@peppy peppy merged commit 95a1556 into ppy:master Jan 17, 2018
@smoogipoo smoogipoo deleted the fix-replays branch February 22, 2018 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomastanck thomastanck thomastanck left review comments

@peppy peppy peppy approved these changes

Assignees
No one assigned
Labels
area:replay
Projects
None yet
Milestone
January 2018
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smoogipoo @peppy @thomastanck