Fix potential test failures due to Setup/SetUpSteps ordering #19453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://teamcity.ppy.sh/buildConfiguration/Osu_Build/4290?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildTestsSection=true
Setup
runs beforeSetUpSteps
, and is used to reconstruct the testscene's dependencies, but the current screen hasn't been exited by this point. The above failure can be reproed in visual tests by running the test two times with:The fix is to move all of this code to
SetUpSteps
. This may also fix other intermittent multiplayer tests, but unsure.