Invert creation of clocks in multi-spectator #19911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems much better. @smoogipoo I made two mostly menial fixes/changes, can you make sure you're okay with them? |
peppy
approved these changes
Aug 23, 2022
|
Looks fine |
|
I've cross-tested this with my gameplay clock changes and it merges and passes tests cleanly. |
This was referenced Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the confusion around how multi-spectator clocks work, I think it's more obvious what's going on if
CatchUpSyncManageris the one creating clocks, and those clocks are passed to the individualPlayerAreas.